Closed
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
nyurik
force-pushed
the
nto-dl_phdr_info
branch
from
14dfa52 to
fc2de42
Compare
Contributor
rustbot
added
stable-nominated
nyurik
force-pushed
the
nto-dl_phdr_info
branch
from
fc2de42 to
1373b95
Compare
nyurik
force-pushed
the
nto-dl_phdr_info
branch
from
1373b95 to
fc2de42
Compare
nyurik
force-pushed
the
nto-dl_phdr_info
branch
from
fc2de42 to
552221b
Compare
Modify QNX NTO `dl_iterate_phdr` to toke `* mut` All other platforms use `* mut`, and while this is technically a breaking change, most likely noone is using it directly. NTO does not define last four fields of the `dl_phdr_info`, so might as well exclude them for cleanliness. v7.0: [link](https://www.qnx.com/developers/docs/7.0.0/index.html#com.qnx.doc.neutrino.lib_ref/topic/d/dl_iterate_phdr.html) v7.1: [link](https://www.qnx.com/developers/docs/7.1/#com.qnx.doc.neutrino.lib_ref/topic/d/dl_iterate_phdr.html) v8.0: [link](https://www.qnx.com/developers/docs/8.0/com.qnx.doc.neutrino.lib_ref/topic/d/dl_iterate_phdr.html?hl=dl_phdr_info) See also rust-lang/backtrace-rs#648
nyurik
force-pushed
the
nto-dl_phdr_info
branch
from
552221b to
5329ef5
Compare
nyurik
changed the title
Contributor
|
Thanks for the separate PR, this can be closed now since I will cherry pick that commit directly once it merges. |
Contributor
|
Closing as superseded by #3815 |
tgross35
removed
the
stable-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify QNX NTO
dl_iterate_phdrto toke* mut. All other platforms use* mut, and while this is technically a breaking change, most likely noone is using it directly.NTO does not define last four fields of the
dl_phdr_info, so might as well exclude them for cleanliness.v7.0: link
v7.1: link
v8.0: link
See also rust-lang/backtrace-rs#648
r? @joshtriplett