Merged
Conversation
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
Contributor
|
Great, thanks! Missing field changes seem fine to me, @joshtriplett already approved the @rustbot label +stable-nominated |
rustbot
added
the
stable-nominated
Modify QNX NTO `dl_iterate_phdr` to toke `* mut` All other platforms use `* mut`, and while this is technically a breaking change, most likely noone is using it directly. NTO does not define last four fields of the `dl_phdr_info`, so might as well exclude them for cleanliness. v7.0: [link](https://www.qnx.com/developers/docs/7.0.0/index.html#com.qnx.doc.neutrino.lib_ref/topic/d/dl_iterate_phdr.html) v7.1: [link](https://www.qnx.com/developers/docs/7.1/#com.qnx.doc.neutrino.lib_ref/topic/d/dl_iterate_phdr.html) v8.0: [link](https://www.qnx.com/developers/docs/8.0/com.qnx.doc.neutrino.lib_ref/topic/d/dl_iterate_phdr.html?hl=dl_phdr_info) See also rust-lang/backtrace-rs#648
auto-merge was automatically disabled
August 13, 2024 01:01
Head branch was pushed to by a user without write access
nyurik
force-pushed
the
nto-dl_phdr_info-main
branch
from
84a21d0 to
4edd266
Compare
This was referenced Aug 13, 2024
tgross35
approved these changes
Aug 13, 2024
Contributor
Author
|
@tgross35 thx, merged! Do you have any aprox release timeline for v0.2 with this functionality? Thx! |
Contributor
|
I'll pick it up in my next batch of backports. Not sure about a release, I can't do them so I would like to get CI automation set up for that. Maybe later this week for that, releases should be trivial once it is done. |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 13, 2024
Modify QNX NTO `dl_iterate_phdr` to toke `* mut` All other platforms use `* mut`, and while this is technically a breaking change, most likely noone is using it directly. NTO does not define last four fields of the `dl_phdr_info`, so might as well exclude them for cleanliness. v7.0: [link](https://www.qnx.com/developers/docs/7.0.0/index.html#com.qnx.doc.neutrino.lib_ref/topic/d/dl_iterate_phdr.html) v7.1: [link](https://www.qnx.com/developers/docs/7.1/#com.qnx.doc.neutrino.lib_ref/topic/d/dl_iterate_phdr.html) v8.0: [link](https://www.qnx.com/developers/docs/8.0/com.qnx.doc.neutrino.lib_ref/topic/d/dl_iterate_phdr.html?hl=dl_phdr_info) See also rust-lang/backtrace-rs#648 (backport <rust-lang#3815>) (cherry picked from commit 4edd266)
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes from #3790 and #3792 applied to the main branch per @tgross35 request
NTO does not define last four fields of the
dl_phdr_info, so might as well exclude them for cleanliness.v7.0: link
v7.1: link
v8.0: link