Modify QNX NTO dl_iterate_phdr to take * mut#3792
Closed
nyurik wants to merge 1 commit intorust-lang:libc-0.2from
Closed
Modify QNX NTO dl_iterate_phdr to take * mut#3792nyurik wants to merge 1 commit intorust-lang:libc-0.2from
dl_iterate_phdr to take * mut#3792nyurik wants to merge 1 commit intorust-lang:libc-0.2from
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Member
|
👍 from me as soon as we sort out CI. |
nyurik
changed the title
dl_iterate_phdr to toke * mutdl_iterate_phdr to take * mut
All other platforms use `* mut`, and while this is technically a breaking change, most likely noone is using it directly. See also rust-lang/backtrace-rs#648
auto-merge was automatically disabled
August 13, 2024 01:02
Head branch was pushed to by a user without write access
nyurik
force-pushed
the
qnx-dl_iterate_phdr
branch
from
22d54ff to
1c7f291
Compare
Contributor
|
Going to close this since it was pulled into #3815. We will target 0.2 with a cherry pick after merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other platforms use
* mut, and while this is technically a breaking change, most likely noone is using it directly.See also rust-lang/backtrace-rs#648
r? @joshtriplett