Skip to content

Switch from Travis/AppVeyor to GitHub Actions#354

Merged
sfackler merged 2 commits into
rust-lang:masterfrom
alexcrichton:switch-to-gh-actions
Sep 3, 2019
Merged

Switch from Travis/AppVeyor to GitHub Actions#354
sfackler merged 2 commits into
rust-lang:masterfrom
alexcrichton:switch-to-gh-actions

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

Switches from running Windows builds in my personal AppVeyor with 1 concurrency to GitHub actions which has much more concurrency.

@alexcrichton
Copy link
Copy Markdown
Member Author

It's worth noting that the additions to CI here are:

  • Rustfmt is run and verified to be clean
  • Windows now runs the same test suites as Linux
  • OSX was added as a test target

Other than that should be the same as before!

@sfackler
Copy link
Copy Markdown
Member

sfackler commented Sep 3, 2019

Worth caching the crates.io index?

@alexcrichton
Copy link
Copy Markdown
Member Author

Seems reasonable to me, but I don't think that actions has caching yet, so that may have to come later

@sfackler sfackler merged commit b366b47 into rust-lang:master Sep 3, 2019
EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
but explicitly enable it in our own builds.

This is because using zlib-ng sometimes does not compile easily on Windows,
and using the pure miniz_oxide offers a better install story from source.

For our binary builds, we can provide the optimal performance, and still
do that for most users as they will update with cargo-binstall, getting our
build as a second pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants