Skip to content

Prepare for 0.4.9 release#368

Merged
KodrAus merged 2 commits into
rust-lang:masterfrom
KodrAus:cargo/0.4.9
Dec 15, 2019
Merged

Prepare for 0.4.9 release#368
KodrAus merged 2 commits into
rust-lang:masterfrom
KodrAus:cargo/0.4.9

Conversation

@KodrAus
Copy link
Copy Markdown
Contributor

@KodrAus KodrAus commented Dec 11, 2019

Changeset since the last release

Minimum supported rustc is being bumped to 1.31.0. This release is just over 12 months old now.

Includes:

This release includes some macro support for our experimental structured logging, which could use some more eyes to make sure we're not missing anything important.

cc @wycats

r? @sfackler @dtolnay @BurntSushi

@KodrAus
Copy link
Copy Markdown
Contributor Author

KodrAus commented Dec 11, 2019

Sorry @wycats 🙂 I meant to cc @yoshuawuyts

Comment thread CHANGELOG.md

This release bumps the minimum compiler version to `1.31.0`. This was mainly needed for `cfg-if`,
but between `1.16.0` and `1.31.0` there are a lot of language and library improvements we now
take advantage of.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 0.5.0 as bumping the minimum rust version is a breaking change, and 0.4.9 is considered semver-compatible — which means this release might break people's builds.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just have to be especially careful about breaking bumps in the log crate, because we have to consider compatibility between different versions of the Log trait.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping the minimum rust version is a breaking change

Just a note that this is not a unanimously held viewpoint in the ecosystem. e.g., cfg-if bumped its MSRV in a semver compatible release. There has been a lot of discussion on this point here: rust-lang/api-guidelines#123

Copy link
Copy Markdown
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough; LGTM!

@KodrAus KodrAus merged commit 87fc152 into rust-lang:master Dec 15, 2019
@KodrAus KodrAus deleted the cargo/0.4.9 branch December 15, 2019 22:29
@KodrAus
Copy link
Copy Markdown
Contributor Author

KodrAus commented Dec 15, 2019

Alrighty, I've published 0.4.9 and posted a note on Reddit about the release.

EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants