Skip to content

Guard patterns: lowering to THIR#153828

Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Human9000-bit:guard-patterns-thir
Mar 21, 2026
Merged

Guard patterns: lowering to THIR#153828
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Human9000-bit:guard-patterns-thir

Conversation

@Human9000-bit
Copy link
Contributor

@Human9000-bit Human9000-bit commented Mar 13, 2026 •
edited by rustbot
Loading

This pr implements lowering of guard patterns to THIR

r? @Nadrieril

cc @max-niederman

Tracking issue: #129967

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 13, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2026

Nadrieril is not on the review rotation at the moment.
They may take a while to respond.

@Human9000-bit Human9000-bit marked this pull request as ready for review March 16, 2026 13:06
@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2026

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred in match checking

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 16, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Human9000-bit
Copy link
Contributor Author

Human9000-bit commented Mar 16, 2026

@bors retry

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 16, 2026

@Human9000-bit: 🔑 Insufficient privileges: not in review users

@rustbot

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Human9000-bit
Copy link
Contributor Author

Human9000-bit commented Mar 20, 2026 •
edited
Loading

Hiii @Nadrieril 👋

Did you have a chance to take a look at this PR? What do you think? just checking in, maybe we should do a reroll if you can't do it

@Nadrieril
Copy link
Member

Nadrieril commented Mar 20, 2026

Hii, sorry I'm wasn't too reactive for reviews lately, lemme have a look

@Nadrieril
Copy link
Member

Nadrieril commented Mar 20, 2026

Oh I was dreading a massive PR but this is short and sweet :) Let's go!

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 20, 2026

📌 Commit 16fc301 has been approved by Nadrieril

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 20, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 20, 2026
@bors
Auto merge of #154151 - JonathanBrouwer:rollup-qLQ5uET, r=JonathanBro…
9e0a42c 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #153828 (Guard patterns: lowering to THIR)
 - #154015 (refactor - moving `check_stability` check to `parse_stability`)
 - #154119 (llvm: Update `reliable_f128` configuration for LLVM22 on Sparc)
 - #154138 (vec::Drain::fill: avoid reference to uninitialized memory)
 - #154143 (test copy_specializes_from_vecdeque: reduce iteration count for Miri)
@rust-bors rust-bors bot merged commit d8b5b46 into rust-lang:main Mar 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Nadrieril Nadrieril

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Human9000-bit @rustbot @rust-log-analyzer @Nadrieril