Skip to content

llvm: Update reliable_f128 configuration for LLVM22 on Sparc#154119

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
tgross35:f128-sparc
Mar 21, 2026
Merged

llvm: Update reliable_f128 configuration for LLVM22 on Sparc#154119
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
tgross35:f128-sparc

Conversation

@tgross35
Copy link
Contributor

LLVM22 should have resolved issues with the f128 ABI, meaning we can now set cfg(target_has_reliable_f128) on the platform.

Link: llvm/llvm-project@3e16aef

Since we're on the topic,
r? @cuviper

LLVM22 should have resolved issues with the `f128` ABI, meaning we can
now set `cfg(target_has_reliable_f128)` on the platform.

Link: llvm/llvm-project@3e16aef
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2026
@tgross35
Copy link
Contributor Author

Hang on, checking something on godbolt
@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 19, 2026
@tgross35
Copy link
Contributor Author

Nevermind, everything looks all good, I just don't know my sparc targets. https://rust.godbolt.org/z/o1ExW4fMY

@rustbot ready

Cc maintainers of sparc targets @psumbera @kulikjak @jonathanpallant: if you get the chance, it would be good to run the testsuite for core and compiler-builtins with this change.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2026
@tgross35
Copy link
Contributor Author

Forgot this exists now,

@bors try jobs=dist-sparcv9-solaris

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 19, 2026
llvm: Update `reliable_f128` configuration for LLVM22 on Sparc


try-job: dist-sparcv9-solaris
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 20, 2026

☀️ Try build successful (CI)
Build commit: c34c21f (c34c21f5a305694a034da4aa11b04aa5c9bf5de9, parent: bcf3d36c997dd9b5db4bb7f40cb91dd4cf46a305)

@cuviper
Copy link
Member

cuviper commented Mar 20, 2026

Looks good - let's go ahead and merge, then the cced maintainers can use an actual nightly build to confirm later.

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 20, 2026

📌 Commit 0d727e5 has been approved by cuviper

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2026
rust-bors bot pushed a commit that referenced this pull request Mar 20, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #153828 (Guard patterns: lowering to THIR)
 - #154015 (refactor - moving `check_stability` check to `parse_stability`)
 - #154119 (llvm: Update `reliable_f128` configuration for LLVM22 on Sparc)
 - #154138 (vec::Drain::fill: avoid reference to uninitialized memory)
 - #154143 (test copy_specializes_from_vecdeque: reduce iteration count for Miri)
@rust-bors rust-bors bot merged commit 8f79cbc into rust-lang:main Mar 21, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 21, 2026
@tgross35 tgross35 deleted the f128-sparc branch March 21, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants