Skip to content

Change ?Sized to PointeeSized in UnwindSafe impls for pointers#153945

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
theemathas:unwind_safe_pointee_sized
Mar 18, 2026
Merged

Change ?Sized to PointeeSized in UnwindSafe impls for pointers#153945
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
theemathas:unwind_safe_pointee_sized

Conversation

@theemathas
Copy link
Contributor

@theemathas theemathas commented Mar 16, 2026 •
edited by rustbot
Loading

Tracking issue: #144404.

This PR is similar to #152646.

@theemathas theemathas added the F-sized_hierarchy `#![feature(sized_hierarchy)]` label Mar 16, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 16, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2026

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, joboet, scottmcm

@scottmcm
Copy link
Member

scottmcm commented Mar 18, 2026

There seem like they're obviously trying to apply to all pointers, which ?Sized used to do, so this makes sense to me.

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 18, 2026

📌 Commit a89211e has been approved by scottmcm

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 18, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153945 - theemathas:unwind_safe_pointee_siz…
3f50f43 
…ed, r=scottmcm

Change `?Sized` to `PointeeSized` in `UnwindSafe` impls for pointers

Tracking issue: rust-lang#144404.

This PR is similar to rust-lang#152646.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 18, 2026
Closed
@Zalathar Zalathar mentioned this pull request Mar 18, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 18, 2026
@bors
Auto merge of #154035 - Zalathar:rollup-ves1pzn, r=Zalathar
70dd5b8 
Rollup of 3 pull requests

Successful merges:

 - #153677 (Remove string content from panics)
 - #153945 (Change `?Sized` to `PointeeSized` in `UnwindSafe` impls for pointers)
 - #153985 (doc: clarify allocator invariant)
@rust-bors rust-bors bot merged commit eeb140d into rust-lang:main Mar 18, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 18, 2026
@theemathas theemathas deleted the unwind_safe_pointee_sized branch March 18, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@scottmcm scottmcm

Labels

F-sized_hierarchy `#![feature(sized_hierarchy)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@theemathas @rustbot @scottmcm