Skip to content

Rollup of 3 pull requests#154035

Merged
rust-bors[bot] merged 7 commits intorust-lang:mainfrom
Zalathar:rollup-ves1pzn
Mar 18, 2026
Merged

Rollup of 3 pull requests#154035
rust-bors[bot] merged 7 commits intorust-lang:mainfrom
Zalathar:rollup-ves1pzn

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Mar 18, 2026

Successful merges:

r? @ghost

Create a similar rollup

ConradIrwin and others added 7 commits March 10, 2026 19:35
@ConradIrwin
Remove string content from panics
05ac9d4 
String content can be useful for debugging panics, particularly when you
are working on a small codebase where you can infer more about the path
taken through your program based on the content of the string.

In production deployments that upload crashes for centralized debugging,
string content poses a risk to user privacy. The string can accidentally
contain information that the user is not expecting to share with the
development team.

On balance it seems like the risks outweigh the benefits. It is easy to
add a `dbg!()` statement to gather more information in development; but
comparatively tricky to ensure panics are sanitized by every rust app
that monitors their production deployments.

Ref https://internals.rust-lang.org/t/stop-including-string-content-in-index-panics/24067
@ConradIrwin @TKanX
Fix tests and tidy up wtf-8 failures
7ec050a 
Co-authored-by: TKanX <124454788+TKanX@users.noreply.github.com>
@theemathas
Change ?Sized to PointeeSized in UnwindSafe impls for pointers
a89211e
@lms0806
doc: clarify allocator invariant
57fe818
@Zalathar
Rollup merge of rust-lang#153677 - ConradIrwin:sanitary-string-panics…
04e7f2f 
…, r=scottmcm

Remove string content from panics

String content can be useful for debugging panics, particularly when you are working on a small codebase where you can infer more about the path taken through your program based on the content of the string.

In production deployments that upload crashes for centralized debugging, string content poses a risk to user privacy. The string can accidentally contain information that the user is not expecting to share with the development team.

On balance it seems like the risks outweigh the benefits. It is easy to add a `dbg!()` statement to gather more information in development; but comparatively tricky to ensure panics are sanitized by every rust app that monitors their production deployments.

Ref https://internals.rust-lang.org/t/stop-including-string-content-in-index-panics/24067

r? @scottmcm
@Zalathar
Rollup merge of rust-lang#153945 - theemathas:unwind_safe_pointee_siz…
eeb140d 
…ed, r=scottmcm

Change `?Sized` to `PointeeSized` in `UnwindSafe` impls for pointers

Tracking issue: rust-lang#144404.

This PR is similar to rust-lang#152646.
@Zalathar
Rollup merge of rust-lang#153985 - lms0806:issue-153542, r=scottmcm
43e4859 
doc: clarify allocator invariant

Added base + size <= usize::MAX to the Allocator documentation.

Please refer to issue [153542](rust-lang#153542).

Close rust-lang#153542
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 18, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 18, 2026
@Zalathar
Copy link
Member Author

Zalathar commented Mar 18, 2026

Rollup of everything.

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 18, 2026

📌 Commit 43e4859 has been approved by Zalathar

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2026
@rust-bors rust-bors bot mentioned this pull request Mar 18, 2026
Merged
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 18, 2026

☀️ Test successful - CI
Approved by: Zalathar
Duration: 3h 30m 43s
Pushing 70dd5b8 to main...

@rust-bors rust-bors bot merged commit 70dd5b8 into rust-lang:main Mar 18, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 18, 2026
@Zalathar Zalathar deleted the rollup-ves1pzn branch March 18, 2026 11:11
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a3903b1 (parent) -> 70dd5b8 (this PR)

Test differences

Show 492 test diffs

Stage 1

  • str::slice_index::test_slice_fail_truncated_2: pass -> [missing] (J0)

Stage 2

  • str::slice_index::test_slice_fail_truncated_2: pass -> [missing] (J1)

Additionally, 490 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 70dd5b8d0e00ce34ecb7612c3b76a0b2f6601ab6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. optional-x86_64-gnu-parallel-frontend: 2h 40m -> 2h 5m (-21.6%)
  2. x86_64-msvc-2: 2h 29m -> 3h 1m (+21.5%)
  3. dist-x86_64-msvc-alt: 2h 40m -> 3h 8m (+17.5%)
  4. dist-x86_64-apple: 1h 53m -> 2h 9m (+14.3%)
  5. tidy: 2m 30s -> 2m 49s (+12.8%)
  6. pr-check-1: 31m 50s -> 27m 57s (-12.2%)
  7. x86_64-gnu-tools: 1h 2m -> 55m 15s (-12.1%)
  8. i686-gnu-nopt-1: 2h 23m -> 2h 6m (-11.9%)
  9. dist-riscv64-linux: 1h 21m -> 1h 30m (+11.1%)
  10. aarch64-gnu-llvm-21-1: 58m 28s -> 52m 8s (-10.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Mar 18, 2026

Finished benchmarking commit (70dd5b8): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.2% [0.1%, 0.3%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -2.2%, secondary -4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)		 -4.1% [-4.1%, -4.1%] 1
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.2%] 52
Regressions ❌
(secondary)		 0.1% [0.0%, 0.1%] 23
Improvements ✅
(primary)		 -0.0% [-0.0%, -0.0%] 2
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) 0.1% [-0.0%, 0.2%] 54

Bootstrap: 481.409s -> 480.328s (-0.22%)
Artifact size: 394.92 MiB -> 396.95 MiB (0.51%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar @rust-timer @rustbot @ConradIrwin @theemathas @lms0806