const validity checking: do not recurse to references inside MaybeDangling#154093
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 24, 2026
Merged
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
|
This comment was marked as resolved.
This comment was marked as resolved.
WaffleLapkin
approved these changes
Mar 23, 2026
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 23, 2026
…=WaffleLapkin
const validity checking: do not recurse to references inside MaybeDangling
This arguably should be allowed, but we currently reject it:
```rust
#![feature(maybe_dangling)]
use std::mem::MaybeDangling;
const X: MaybeDangling<&bool> = unsafe { std::mem::transmute(&5u8) };
```
r? @WaffleLapkin
This was referenced Mar 23, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
…uwer Rollup of 8 pull requests Successful merges: - #122668 (Add APIs for dealing with titlecase) - #153041 (Remove `ATTRIBUTE_ORDER`) - #153912 (Avoid prematurely choosing a glob import) - #154093 (const validity checking: do not recurse to references inside MaybeDangling) - #154257 (Revert eagerly normalize in generalize) - #154179 (tests/ui/async-await/gat-is-send-across-await.rs: New regression test) - #154224 (Remove more `BuiltinLintDiag` variants) - #154245 (Allow applying autodiff macros to trait functions.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This arguably should be allowed, but we currently reject it:
r? @WaffleLapkin