Skip to content

Revert eagerly normalize in generalize#154257

Merged
rust-bors[bot] merged 12 commits intorust-lang:mainfrom
jdonszelmann:revert-eagerly-normalize-in-generalize
Mar 24, 2026
Merged

Revert eagerly normalize in generalize#154257
rust-bors[bot] merged 12 commits intorust-lang:mainfrom
jdonszelmann:revert-eagerly-normalize-in-generalize

Conversation

@jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Mar 23, 2026

r? @lcnr

Reverts #151746

We'll likely pull eager normalization out of generalization

Fixes #154173
Fixes #154244

@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2026

changes to the core type system

cc @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Mar 23, 2026
@lqd
Copy link
Member

lqd commented Mar 23, 2026

If you want to do that, you can revert the single bors merge commit instead of all commits in the PR.

@lcnr
Copy link
Contributor

lcnr commented Mar 23, 2026

@lqd do you think doing that is blocking?

otherwise r=me

@lqd
Copy link
Member

lqd commented Mar 23, 2026

It should be an easy fix, with git revert ac7f9ec7da74d37fd28667c86bf117a39ba5b02a -m 1

@lqd
Copy link
Member

lqd commented Mar 23, 2026

today is not the day, let's land this as-is

@bors r=lcnr

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 23, 2026

📌 Commit e28b485 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 23, 2026
…ize-in-generalize, r=lcnr

Revert eagerly normalize in generalize

r? @lcnr

Reverts rust-lang#151746

We'll likely pull eager normalization out of generalization

Fixes rust-lang#154173
Fixes rust-lang#154244
rust-bors bot pushed a commit that referenced this pull request Mar 23, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #122668 (Add APIs for dealing with titlecase)
 - #153041 (Remove `ATTRIBUTE_ORDER`)
 - #153912 (Avoid prematurely choosing a glob import)
 - #154093 (const validity checking: do not recurse to references inside MaybeDangling)
 - #154257 (Revert eagerly normalize in generalize)
 - #154179 (tests/ui/async-await/gat-is-send-across-await.rs: New regression test)
 - #154224 (Remove more `BuiltinLintDiag` variants)
 - #154245 (Allow applying autodiff macros to trait functions.)
@rust-bors rust-bors bot merged commit 7f8f600 into rust-lang:main Mar 24, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

4 participants