Skip to content

add neon load/store assembly test#154094

Open
folkertdev wants to merge 1 commit intorust-lang:mainfrom
folkertdev:aarch64-arm-load-store
Open

add neon load/store assembly test#154094
folkertdev wants to merge 1 commit intorust-lang:mainfrom
folkertdev:aarch64-arm-load-store

Conversation

@folkertdev
Copy link
Contributor

I'm adding this test because it was requested for the beta backport of #153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 19, 2026
add neon load/store assembly test


try-job: test-various
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 19, 2026

☀️ Try build successful (CI)
Build commit: 3ca1cdd (3ca1cddaf6b5c74ff9a96d233c411d3d3b287e56, parent: 8b86f48958be8c3473c979e0b5504c2d2e0fd4fd)

@sayantn
Copy link
Contributor

sayantn commented Mar 21, 2026

LGTM, and the test pass too!

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 21, 2026

📌 Commit d2c1b74 has been approved by sayantn

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 21, 2026
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
@JonathanBrouwer
Copy link
Contributor

@bors r-
#154186 (comment)

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 21, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 21, 2026

This pull request was unapproved.

This PR was contained in a rollup (#154186), which was unapproved.

@folkertdev folkertdev force-pushed the aarch64-arm-load-store branch from d2c1b74 to b44f9c1 Compare March 21, 2026 20:18
@folkertdev
Copy link
Contributor Author

apple formats the assembly slightly differently

@bors try job=aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 21, 2026
add neon load/store assembly test


try-job: aarch64-apple
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 21, 2026

☀️ Try build successful (CI)
Build commit: e06bfca (e06bfca40233a0d515ec80cdd93369d0e4c8e7a5, parent: 20f19f4615200b16e3631816e7824e832ff394db)

@JonathanBrouwer
Copy link
Contributor

@bors r=sayantn

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 21, 2026

📌 Commit b44f9c1 has been approved by sayantn

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 21, 2026
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
rust-bors bot pushed a commit that referenced this pull request Mar 22, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #122668 (Add APIs for dealing with titlecase)
 - #153312 (Packages as namespaces part 1)
 - #153534 (Remove a flaky `got_timeout` assert from two channel tests)
 - #154094 (add neon load/store assembly test)
 - #154175 (Add new alias for Guillaume Gomez email address)
 - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl)
 - #154188 (Update the tracking issue for #[diagnostic::on_move])
@Zalathar
Copy link
Member

Failed in rollup in armhf-gnu: #154192 (comment)

@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 22, 2026

This pull request was unapproved.

This PR was contained in a rollup (#154192), which was unapproved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants