Skip to content

Rollup of 7 pull requests#154192

Closed
JonathanBrouwer wants to merge 15 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-TkGjSDo
Closed

Rollup of 7 pull requests#154192
JonathanBrouwer wants to merge 15 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-TkGjSDo

Conversation

@JonathanBrouwer
Copy link
Contributor

Successful merges:

r? @ghost

Create a similar rollup

Zalathar and others added 15 commits March 7, 2026 21:16
In CI, the receiver thread can be descheduled for a surprisingly long time, so
there's no guarantee that a timeout actually occurs.
Avoid an ICE for:

    struct A;
    impl A<B> {}

The compiler no longer panics and can proceed to emit existing diagnostics.

Adds `tests/ui/missing/undeclared-generic-parameter.rs`.

Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Now that the tracking issue has been opened, point to it.
- `char::is_cased`
- `char::is_titlecase`
- `char::case`
- `char::to_titlecase`
…Simulacrum

Add APIs for dealing with titlecase

ACP: rust-lang/libs-team#354
Tracking issue: rust-lang#153892

r? libs-api

@rustbot label T-libs -T-libs-api A-unicode

~~The last commit has some insta-stable `PartialEq` impls, therefore: @rustbot label -needs-fcp
Alternatively, I could split those out into a follow-up PR.~~ (Edit: will do in follow-up)
…, r=petrochenkov

Packages as namespaces part 1

Part 1 of rust-lang#152299

r? @petrochenkov
…lacrum

Remove a flaky `got_timeout` assert from two channel tests

In CI, the receiver thread can be descheduled for a surprisingly long time, so there's no guarantee that a timeout actually occurs.

One of these tests actually failed in rust-lang#153387 (comment).

Earlier failures:
- rust-lang#150365 (comment)
- rust-lang#147775 (comment)

---

- Prior art: rust-lang#152878
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
…ulacrum

Add new alias for Guillaume Gomez email address

I'm switching to a new email account and slowly updating all references to the old one.
…tebank

diagnostics: avoid ICE for undeclared generic parameter in impl

Avoid an ICE for:

    struct A;
    impl A<B> {}

The compiler no longer panics and can proceed to emit existing diagnostics.

Adds `tests/ui/missing/undeclared-generic-parameter.rs`.

Fixes rust-lang#154165 and introduced by rust-lang#152913
…o_the_tracking_issue, r=JonathanBrouwer

Update the tracking issue for #[diagnostic::on_move]

PR rust-lang#150935 has been merged and then I have opened the tracking issue (whoops ?). So this update `compiler/rustc_feature/src/unstable.rs` to point to the right tracking issue.

This is related to the tracking issue rust-lang#154181
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 21, 2026
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 21, 2026
@JonathanBrouwer
Copy link
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 21, 2026

📌 Commit e271e12 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer
Copy link
Contributor Author

Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 21, 2026

⌛ Trying commit e271e12 with merge e3674d6

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/23391372960

rust-bors bot pushed a commit that referenced this pull request Mar 21, 2026
Rollup of 7 pull requests


try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 22, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #122668 (Add APIs for dealing with titlecase)
 - #153312 (Packages as namespaces part 1)
 - #153534 (Remove a flaky `got_timeout` assert from two channel tests)
 - #154094 (add neon load/store assembly test)
 - #154175 (Add new alias for Guillaume Gomez email address)
 - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl)
 - #154188 (Update the tracking issue for #[diagnostic::on_move])
@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [assembly] tests/assembly-llvm/aarch64-arm-load-store.rs#ARMV7 stdout ----
------rustc stdout------------------------------

------rustc stderr------------------------------
error[E0425]: cannot find type `float32x4x3_t` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:25:39
   |
25 | fn test_vld3q_f32(ptr: *const f32) -> float32x4x3_t {
   |                                       ^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find type `int32x4x3_t` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:44:39
   |
44 | fn test_vld3q_s32(ptr: *const i32) -> int32x4x3_t {
   |                                       ^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find type `uint32x4x3_t` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:63:39
   |
63 | fn test_vld3q_u32(ptr: *const u32) -> uint32x4x3_t {
   |                                       ^^^^^^^^^^^^
   |
  --> /rustc/FAKE_PREFIX/library/core/src/../../stdarch/crates/core_arch/src/arm/simd32.rs:78:0
   |
   = note: similarly named type alias `uint8x4_t` defined here
help: a type alias with a similar name exists
   |
63 - fn test_vld3q_u32(ptr: *const u32) -> uint32x4x3_t {
63 + fn test_vld3q_u32(ptr: *const u32) -> uint8x4_t {
   |

warning: unused import: `std::arch::arm::*`
##[warning]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:18:5
   |
18 | use std::arch::arm::*;
   |     ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

error[E0425]: cannot find function `vld3q_f32` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:39:14
   |
39 |     unsafe { vld3q_f32(ptr) }
   |              ^^^^^^^^^ not found in this scope

error[E0425]: cannot find function `vld3q_s32` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:58:14
   |
58 |     unsafe { vld3q_s32(ptr) }
   |              ^^^^^^^^^ not found in this scope

error[E0425]: cannot find function `vld3q_u32` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:77:14
   |
77 |     unsafe { vld3q_u32(ptr) }
   |              ^^^^^^^^^ not found in this scope

error: aborting due to 6 previous errors; 1 warning emitted

For more information about this error, try `rustc --explain E0425`.

------------------------------------------

error in revision `ARMV7`: compilation failed!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/assembly-llvm/aarch64-arm-load-store.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=arm-unknown-linux-gnueabihf" "--cfg" "armv7" "--check-cfg" "cfg(test,FALSE,aarch64,armv7)" "-O" "-Cdebug-assertions=no" "-Zcodegen-source-order" "--emit" "asm" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/aarch64-arm-load-store.ARMV7/aarch64-arm-load-store.s" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Clinker=arm-linux-gnueabihf-gcc" "-Copt-level=3"
stdout: none
--- stderr -------------------------------
error[E0425]: cannot find type `float32x4x3_t` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:25:39
   |
25 | fn test_vld3q_f32(ptr: *const f32) -> float32x4x3_t {
   |                                       ^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find type `int32x4x3_t` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:44:39
   |
44 | fn test_vld3q_s32(ptr: *const i32) -> int32x4x3_t {
   |                                       ^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find type `uint32x4x3_t` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:63:39
   |
63 | fn test_vld3q_u32(ptr: *const u32) -> uint32x4x3_t {
   |                                       ^^^^^^^^^^^^
   |
  --> /rustc/FAKE_PREFIX/library/core/src/../../stdarch/crates/core_arch/src/arm/simd32.rs:78:0
   |
   = note: similarly named type alias `uint8x4_t` defined here
help: a type alias with a similar name exists
   |
63 - fn test_vld3q_u32(ptr: *const u32) -> uint32x4x3_t {
63 + fn test_vld3q_u32(ptr: *const u32) -> uint8x4_t {
   |

warning: unused import: `std::arch::arm::*`
##[warning]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:18:5
   |
18 | use std::arch::arm::*;
   |     ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

error[E0425]: cannot find function `vld3q_f32` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:39:14
   |
39 |     unsafe { vld3q_f32(ptr) }
   |              ^^^^^^^^^ not found in this scope

error[E0425]: cannot find function `vld3q_s32` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:58:14
   |
58 |     unsafe { vld3q_s32(ptr) }
   |              ^^^^^^^^^ not found in this scope

error[E0425]: cannot find function `vld3q_u32` in this scope
##[error]  --> /checkout/tests/assembly-llvm/aarch64-arm-load-store.rs:77:14
   |
77 |     unsafe { vld3q_u32(ptr) }
   |              ^^^^^^^^^ not found in this scope

error: aborting due to 6 previous errors; 1 warning emitted

For more information about this error, try `rustc --explain E0425`.

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 22, 2026

💔 Test for 1cd6ddd failed: CI. Failed job:

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 22, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 22, 2026

PR #154094, which is a member of this rollup, was unapproved.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2026
@Zalathar Zalathar closed this Mar 22, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants