Skip to content

Conversation

@baskerville
Copy link
Contributor

In the context of the stack/heap example (1 GiB of RAM), the highest possible memory address is 2^30 - 1.

Correlated minor fixes/enhancements:

  • Use the correct, standardised, term for 2^30 bytes: a gibibyte.
  • Replace <sup>x</sup> by ^x^ (pandoc translates the latter to the former).

r? @steveklabnik

In the context of the stack/heap example (1 GiB of RAM), the highest
possible memory address is 2^30 - 1.

Correlated minor fixes/enhancements:
- Use the correct, standardised, term for 2^30 bytes: a gibibyte.
- Replace <sup>x</sup> by ^x^ (`pandoc` translates the latter to the former).
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Contributor

Even though "gibibyte" is technically correct, nobody actually uses it, so I'm not sure this is actually an improvement.

We don't use pandoc to render the docs, did you verify this renders correctly?

@baskerville
Copy link
Contributor Author

  • I can understand the will to use popular terms, but the problem is that one gigabyte is 10^9 bytes.
  • I made an incorrect assumption, sorry about that. This feature is probably only available in pandoc's variant of Markdown. I tried to build trpl only but I couldn't find the appropriate target: there's a docs target but it builds the whole documentation and seems to take ages to complete.

Since there's multiple ways of fixing the off-by-one error, I think I would rather create an issue for this and let the Rust team decide on how to address it.

@steveklabnik
Copy link
Contributor

make trpl should build the book.

And yeah, thanks! Did you hear that we're going to end up with the book published? I'll be interested to hear what my editor thinks.

Did you end up opening that issue, or did I miss it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants