Skip to content

Conversation

@alexispurslane
Copy link
Contributor

Pointed out by @baskerville #28461.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Contributor

Thanks @ChristopherDumas ! Unfortunately, the reason that we moved that to an issue is that I closed #28441, until we figure out what we want to do. And if we do decide to resolve it, I would like @baskerville's original PR to get merged, since they had it first. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants