Skip to content

Conversation

@tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is becoming more common throughout the standard library as I go through things, so it should stay.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not needed since there is no "Advanced usage" example

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's about consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call it consistency if it was everywhere, but it isn't.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also remove all those instances, unless they were accompanied with "Advanced usage" examples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I go through the docs, I'm adding them, so this will become gradually so over time.

@alexcrichton
Copy link
Member

r? @steveklabnik

@bors
Copy link
Collaborator

bors commented Nov 3, 2015

☔ The latest upstream changes (presumably #29509) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik
Copy link
Contributor

I think I'm 👎 on this PR overall. Extra explanation is good. Docs don't have to be terse.

@tshepang tshepang deleted the trim branch November 3, 2015 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants