Skip to content

Conversation

@vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Nov 1, 2015

The current readme provides critical information about gcc versions too late in the flow.

r? @steveklabnik

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be a note in bold below the header? The pluses look weird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in a code block, normal formatting doesn't work there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Could you still move it to another line and use stars to make it stand out?

@alexcrichton
Copy link
Member

@bors: r+ 363deb0 rollup

@bors
Copy link
Collaborator

bors commented Nov 3, 2015

⌛ Testing commit 363deb0 with merge 5b87225...

bors added a commit that referenced this pull request Nov 3, 2015
The current readme provides critical information about gcc versions too late in the flow.

r? @steveklabnik
@bors bors merged commit 363deb0 into rust-lang:master Nov 3, 2015
@vadimcn vadimcn deleted the readme branch July 14, 2016 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants