Expose all methods of IBuilderConfig#15
Conversation
theHamsta
force-pushed
the
expose-builder-config
branch
6 times, most recently
from
74cdbae to
1b54348
Compare
It's considered and tested in CI. MacOS can also build and execute the real config. MacOS will just fail on dynamic loading since it can't find the library |
theHamsta
force-pushed
the
expose-builder-config
branch
from
c280986 to
c2db198
Compare
|
I integrated #23 into this PR. This way the enums stay |
trtx-sys/generate_debug_enum.sh
Outdated
| sed -i 's/nvinfer1_//g' src/enums.rs | ||
| #sed -i 's/"!/"/g' src/enums.rs | ||
| #sed -i 's/\\n!/\\n/g' src/enums.rs | ||
| cargo fmt |
There was a problem hiding this comment.
We could do this in build.rs just like with autocxx. I generally like to see the generated bindings and also their diff when we change something about binding generation (e.g. we can review something that we want/don't want to be generated). Rust tooling tends to work a bit better when not needing to find generated bindings in the target directory
There was a problem hiding this comment.
We should do this in build.rs to not introduce a bash requirement.
theHamsta
force-pushed
the
expose-builder-config
branch
from
c2db198 to
6523dc0
Compare
mtavenrath
left a comment
mtavenrath
left a comment
There was a problem hiding this comment.
I'd like to see generate_debug_enum.sh in build.rs to avoid manual steps and the requirement of a bash. Besides that Approved.
trtx-sys/generate_debug_enum.sh
Outdated
| sed -i 's/nvinfer1_//g' src/enums.rs | ||
| #sed -i 's/"!/"/g' src/enums.rs | ||
| #sed -i 's/\\n!/\\n/g' src/enums.rs | ||
| cargo fmt |
There was a problem hiding this comment.
We should do this in build.rs to not introduce a bash requirement.
theHamsta
force-pushed
the
expose-builder-config
branch
from
6523dc0 to
62067ad
Compare
theHamsta
force-pushed
the
expose-builder-config
branch
from
86cb0c3 to
d7b3e6f
Compare
|
It's now generated using |
2 participants
Primary motivation is ProfilingVerbosity, but I thought I could add the reset also.
Breaking change since it removes the old
trtx::builder::MemoryPoolTypeand replaces it with the generated type.Need to make the generated Eq,Debug before-> Debug provided by bindgen generated type