Merged
Conversation
theHamsta
force-pushed
the
expose-ihostmemory
branch
2 times, most recently
from
a182431 to
f32a9b0
Compare
theHamsta
force-pushed
the
expose-ihostmemory
branch
2 times, most recently
from
c8aece0 to
d1da54f
Compare
theHamsta
force-pushed
the
expose-ihostmemory
branch
from
d1da54f to
2478f4f
Compare
This avoids needing to copy the engine memory to a vector. Fixes rustnn#17
theHamsta
force-pushed
the
expose-ihostmemory
branch
from
2874493 to
810b0cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #15 .
Follow up for #15
IHostMemorydirectly. We don't want to copy engines. Since we implementDeref<&[u8]>/AsRef<&[u8]>for it, it behaves API-wise like theVec<u8>from the mock side.Fixes #17