Bugfix for drawing RandomEncodingCircuit#371
Merged
MoritzWillmann merged 3 commits intosQUlearn:developfrom Jan 7, 2026
Merged
Bugfix for drawing RandomEncodingCircuit#371MoritzWillmann merged 3 commits intosQUlearn:developfrom
MoritzWillmann merged 3 commits intosQUlearn:developfrom
Conversation
Collaborator
|
Hey @kit0kat, thanks for catching and fixing this. I'll get this merged ASAP 😄 |
MoritzWillmann
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a bug when drawing a
RandomEncodingCircuit.Minimal re-produceable code (run in a jupyter notebook with matplotlib installed):
❌ TypeError: '>' not supported between instances of 'NoneType' and 'int'
❌ TypeError: '>' not supported between instances of 'NoneType' and 'int'
❌ ValueError: Number of features in the input data (1) does not match the number of features in the encoding circuit (3).
This PR proposes a possible fix for the
draw()method that seems to work for all 4 cases.