Skip to content

Bugfix for drawing RandomEncodingCircuit #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoritzWillmann merged 3 commits into from
Jan 7, 2026
Merged

Bugfix for drawing RandomEncodingCircuit #371

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
182ddb6
Fix: Draw RandomEncodingCircuit
kit0kat Dec 19, 2025
3b27c07
Merge branch 'develop' into fix/draw-random-encoding-circuit
MoritzWillmann Jan 7, 2026
29650d5
black
MoritzWillmann Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/squlearn/encoding_circuit/encoding_circuit_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,16 @@ def draw(
):
feature_vec = ParameterVector(feature_label, self.num_encoding_slots)

elif self.num_features is not None and num_features is None:
feature_vec = ParameterVector(feature_label, self.num_features)
elif num_features or self.num_features:
feature_vec = ParameterVector(feature_label, num_features or self.num_features)
else:
feature_vec = [Parameter(feature_label)]

# ensure random configuration is available
if hasattr(self, "_is_config_available") and not self._is_config_available:
self._gen_random_config(num_features=num_features, seed=self.get_params()["seed"])
self._gen_random_config(
num_features=num_features or self.num_features or 0, seed=self.get_params()["seed"]
)

# ensure that the LayeredEncodingCircuit is built before drawing
if hasattr(self, "_build_layered_pqc"):
Expand Down
Loading