LT-1633 fixed incorrect JSON logic behaviour for null var values by andras-markos · Pull Request #1 · sailthru/json-logic-java

andras-markos · 2025-08-13T02:54:10Z

Summary

This PR fixes an issue in the JSONLogic Java implementation where null values are incorrectly treated as missing (not present) instead of present but empty. This behavior can cause LO flows to trigger incorrectly.

For full background, see the JSONLogic Java library wiki page.

Changes in this PR

Upstream sync: Incorporates fixes from the original library (v1.0.5 → v1.1.0).
Bug fix: Correctly distinguish between null and missing values in JSONLogic evaluation.
Code style: Reformats code to standard Java conventions and applies minor safe refactors to pass Checkstyle (e.g., added missing newlines, split long lines, removed redundant braces).
Build & release: Updates Gradle and CircleCI config to follow Sailthru’s standard process for releasing JVM libraries and publishing to AWS CodeArtifact.

Review Notes

Changes are grouped into separate commits — reviewing commit-by-commit is recommended.
Use GitHub’s "Ignore whitespace changes" option for a clearer view of logic changes.

`in` of strings would fail with NullPointerException if the first argument was `null`. Also add some tests with null in various places.

When missing_some is applied to a `null` data object, it would return all its arguments, including the threshold. According to the spec, it should return an array of the missing keys. Also, if the threshold is 0, it should always return an empty list, even when data is `null`.

Fix bug in missing_some

…ring Avoid NullPointerException if first argument to "in" is null

…f_operations Removed the redundant storage of operations

* Initial commit for Github actions * Make uploadArchives conditional on the presence of Sonatype credentials * Turn off signing conditionally * Really make signing optional * Add testing output * Test publish step * Attempt to fix path for upload-artifacts action * Use v4 for upload/download-artifacts * Fix signing logic to use in memory keys * Fix push logic in the bump version step * Use checkout@v4 * Add a rebase before committing * Hard-code branch name... * Prepare version 1.0.9-SNAPSHOT for development [skip ci] * Prepare for merge * Remove .vscode folder * Add .vscode to the .gitignore * Split into multiple files * Prepare version 1.0.9-SNAPSHOT for development [skip ci] * Clean up TODOs --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…esso#50)

* Run publish action when a merge is performed on the main branch (is this really how you do it? yuck...) * Github actions fix

…alid array" (jamsesso#42) Added tests for different "all in" cases. Co-authored-by: Rickard Katz <rickard.katz@tactel-ext.se> Co-authored-by: Sam Jesso <samuel.jesso@gmail.com>

…so#53) * Adds jsonPath to error messages, so errors can be pinpointed. The jsonPath can be used to provide better error messages to users trying to create valid jsonLogic expressions Also: Fixes some exception messages to use the right operator. ("none", "or"). Aligns behavior to reference implementation for sums of unparseable strings, as well as for between comparisons of > and >=, and for comparison operators with arrays of more than three values. * Handles edge cases of + and * the way jsonlogic.com does When presented with an array parameter, jsonlogic.com uses the first value for + and * expressions. * Uses fixtures for the error tests. Also fixes a bug in the jsonPath calculation for and/or. * Bump version to 1.1.0-SNAPSHOT

…esso#55)

…y treated as missing

…emoved unnecessary blank line, removed unnecessary braces, simplified return expression, added hashCode method to make checkstyle pass

…p id

bge-kernel-panic · 2025-08-13T15:59:03Z

@andras-markos I think we're trying to do too much at once here, witness the fact that the build fails. I know they're separate commits but I'm having a hard time figuring out what you changed even there.

This thing is still running github actions.

I'd recommend the following sequence:

First incorporate the upstream changes, to ensure old github actions still work
Create a branch here for just your change (no reformatting nothing) so you can submit it upstream
Then update to use circleci (don't forget to get rid of the github actions...). Initially you can turn checkstyle off.
Finally do your actual changes, it's ok if reformatting is included in there, but I really think it's hard to take on everything at once. You can cherry pick your fix from 2. above.

andras-markos · 2025-08-15T05:24:10Z

@andras-markos I think we're trying to do too much at once here, witness the fact that the build fails. I know they're separate commits but I'm having a hard time figuring out what you changed even there.

This thing is still running github actions.

I'd recommend the following sequence:

First incorporate the upstream changes, to ensure old github actions still work

Create a branch here for just your change (no reformatting nothing) so you can submit it upstream

Then update to use circleci (don't forget to get rid of the github actions...). Initially you can turn checkstyle off.

Finally do your actual changes, it's ok if reformatting is included in there, but I really think it's hard to take on everything at once. You can cherry pick your fix from 2. above.

I split this PR into more smaller PRs.
I'll decline this one.

andras-markos · 2025-08-15T05:26:24Z

Deleted the feature branch as well.

magnarn and others added 24 commits December 30, 2021 10:35

Avoid NullPointerException if first argument is null

f1f18fe

`in` of strings would fail with NullPointerException if the first argument was `null`. Also add some tests with null in various places.

Merge pull request jamsesso#22 from magnarn/magnarn/bugfix/missing-some

ea9e513

Fix bug in missing_some

Merge pull request jamsesso#23 from magnarn/magnarn/bugfix/null-in-st…

e89792d

…ring Avoid NullPointerException if first argument to "in" is null

Release 1.0.7

33cbec0

Prepare for release 1.0.8

f18c726

Removed the redundant storage of operations

582abac

Merge pull request jamsesso#40 from melniknow/fix/redundant_storage_o…

421d7ba

…f_operations Removed the redundant storage of operations

Run publish action when a merge is performed on the main branch (jams…

f15e172

…esso#50)

Run publish job on push, not merge (jamsesso#51)

3e7b8cf

* Run publish action when a merge is performed on the main branch (is this really how you do it? yuck...) * Github actions fix

Update ref to main

aaf139e

Prepare version 1.0.9-SNAPSHOT for development [skip ci]

ac4b313

Update README.md to remove CI notice (jamsesso#52) [skip ci]

15b2805

The "all" operation will fail with "first argument to all must be a v…

7b7b233

…alid array" (jamsesso#42) Added tests for different "all in" cases. Co-authored-by: Rickard Katz <rickard.katz@tactel-ext.se> Co-authored-by: Sam Jesso <samuel.jesso@gmail.com>

Prepare version 1.0.10-SNAPSHOT for development [skip ci]

b0f2395

Prepare version 1.1.1-SNAPSHOT for development [skip ci]

4aa03e7

Update README version to 1.1.0 [skip ci]

6585a24

Fixes bug arising from operating on empty arrays in '+' and '*' (jams…

96f0582

…esso#55)

[LT-1633] LT-1633 fixed variable logic as null values were incorrectl…

199ffee

…y treated as missing

[LT-1633] LT-1633 updated Gradle build for Sailthru, updated README

a6081b2

[LT-1633] LT-1633 reformatted whole code base, shortened long line, r…

8290d96

…emoved unnecessary blank line, removed unnecessary braces, simplified return expression, added hashCode method to make checkstyle pass

[LT-1633] LT-1633 added CircleCI config, updated README, changed grou…

f5bb45f

…p id

andras-markos had a problem deploying to snapshot August 13, 2025 02:54 — with GitHub Actions Failure

andras-markos requested a review from a team August 13, 2025 02:54

andras-markos closed this Aug 15, 2025

andras-markos deleted the LT-1633-Incorrect-JSONLogic-behaviour-for-watched-content-changed-evaluation-when-null-value-provided branch August 15, 2025 05:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LT-1633 fixed incorrect JSON logic behaviour for null var values#1

LT-1633 fixed incorrect JSON logic behaviour for null var values#1
andras-markos wants to merge 24 commits intomasterfrom
LT-1633-Incorrect-JSONLogic-behaviour-for-watched-content-changed-evaluation-when-null-value-provided

andras-markos commented Aug 13, 2025

Uh oh!

bge-kernel-panic commented Aug 13, 2025

Uh oh!

andras-markos commented Aug 15, 2025

Uh oh!

andras-markos commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

andras-markos commented Aug 13, 2025

Summary

Changes in this PR

Review Notes

Uh oh!

bge-kernel-panic commented Aug 13, 2025

Uh oh!

andras-markos commented Aug 15, 2025

Uh oh!

andras-markos commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants