Allow to opt out of classic component patching#251
Merged
dfreeman merged 1 commit intosalsify:masterfrom Nov 19, 2021
SergeAstapov:fn/opt-out-ember-global
Merged
Allow to opt out of classic component patching#251dfreeman merged 1 commit intosalsify:masterfrom SergeAstapov:fn/opt-out-ember-global
dfreeman merged 1 commit intosalsify:masterfrom
SergeAstapov:fn/opt-out-ember-global
Conversation
Contributor
Author
|
Wonder if @jamescdavis or @dfreeman may release as a new patch version to help upgrading apps and prepare for Ember v4 |
Contributor
Author
|
This similar to #241 but allows to opt-out of monkey-patching behavior before v2 of this addon gets released |
Member
|
Thank you @SergeAstapov! I'm not sure why CI isn't running here, but I'm aiming to get a minor release out with this today and hopefully a major v2 with the monkeypatching and other old crusty stuff removed entirely soon thereafter! |
Contributor
Author
|
@dfreeman thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opt-in to address #237 until a breaking release is made.
This would allow you to specify:
Avoid the deprecation
Reopening the Ember.Component super class itself is deprecatedif you do not use classic components (or the bindings on classic components, at least).Thanks to @Turbo87 and @mydea for idea.
Closes #237.