fix(config): write config dictionary to daemon.json#282
Merged
noelmcloughlin merged 6 commits intosaltstack-formulas:masterfrom Apr 21, 2021
Merged
Conversation
Contributor
Author
|
I just noticed that, according to the toplevel README, the |
5a238e0 to
6755e4a
Compare
An empty daemon.json isn't accepted on some OS/docker versions
6755e4a to
3631fdb
Compare
Contributor
|
Thanks for the PR, @danny-smit. @noelmcloughlin @hatifnatt Would either of you mind reviewing this PR, since you've both been recently active here? |
noelmcloughlin
approved these changes
Apr 21, 2021
Contributor
noelmcloughlin
left a comment
There was a problem hiding this comment.
LGTM. CI passing. Fixes bug #257 thanks @danny-smit
Please add a CI test in future PR if you have time.
Contributor
|
Thanks @danny-smit this is a big one for us couldn't have had better timing |
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
19 tasks
19 tasks
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No
Related issues and/or pull requests
Bug: Can't manage /etc/docker/daemon.json using pillar syntax in v1.0.0 (#257)
Describe the changes you're proposing
This change makes the pillar key
daemon_configupdate the /etc/docker/daemon.json.Pillar / config required to test the proposed changes
Fictive example configuration:
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context