fix(config): remove daemon.json in clean states#284
Merged
myii merged 1 commit intosaltstack-formulas:masterfrom Apr 23, 2021
Merged
fix(config): remove daemon.json in clean states#284myii merged 1 commit intosaltstack-formulas:masterfrom
myii merged 1 commit intosaltstack-formulas:masterfrom
Conversation
myii
suggested changes
Apr 23, 2021
Contributor
There was a problem hiding this comment.
Thanks for the PR, @danny-smit. When fixing the rubocop violation, would you mind rebasing on the latest commit here? I was just in the process of adding the latest pre-salted images when you submitted this PR!
Remove the daemon.json when the clean states are called Also extends tests to verify daemon.json content
danny-smit
force-pushed
the
tests-for-daemon-json-file
branch
from
511d61b to
6967a98
Compare
myii
approved these changes
Apr 23, 2021
Contributor
|
Nice work, thanks @danny-smit -- merged. |
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the daemon.json when the clean states are called
Also extends tests to verify daemon.json content en cleanup.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
#282
#283
Describe the changes you're proposing
Follow up on the previous pull requests #282 and #283 to:
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context