Add the "fingerprint_hash_type" option to ssh state and module#40543
Merged
cachedout merged 1 commit intosaltstack:2016.11from Apr 5, 2017
Merged
Add the "fingerprint_hash_type" option to ssh state and module#40543cachedout merged 1 commit intosaltstack:2016.11from
cachedout merged 1 commit intosaltstack:2016.11from
Conversation
Fixes saltstack#40005 This new option allows the user to specify what kind of hash was used when the public key was hashed to a fingerprint. The default hash is md5, but the user should be able to specify this if they know what the fingerprint was originally hashed with.
|
@rallytime, thanks for your PR! By analyzing the history of the files in this pull request, we identified @imankulov, @jfindlay and @jahamn to be potential reviewers. |
cachedout
approved these changes
Apr 5, 2017
rallytime
pushed a commit
to rallytime/salt
that referenced
this pull request
Apr 26, 2017
rallytime
pushed a commit
to rallytime/salt
that referenced
this pull request
Jun 19, 2017
In PR saltstack#40543, the fingerprint_hash_type option was added to the state function in salt/states/ssh_known_hosts.py, as well as the function in the ssh execution module that the ssh_known_hosts states called out to. This caused issue saltstack#40878 because the fingerprint_hash_type state setting was not added to the salt/states/ssh_auth.py file. This PR adds this setting to the ssh_auth file, as well as the functions that are used in the ssh execution module. This allows the user to set the fingerprint_hash_type option so avoid the warnings about the default changing. Fixes saltstack#40878
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new option allows the user to specify what kind of hash was used when the public key was hashed to a fingerprint. The default hash is md5, but the user should be able to specify this if they know what the fingerprint was originally hashed with.
Fixes #40005