Update fingerprint hash type default from md5 to sha256#41194
Merged
cachedout merged 2 commits intosaltstack:nitrogenfrom May 12, 2017
Merged
Update fingerprint hash type default from md5 to sha256#41194cachedout merged 2 commits intosaltstack:nitrogenfrom
cachedout merged 2 commits intosaltstack:nitrogenfrom
Conversation
This PR also removes the warnings that this default with change in the Nitrogen release, updates the documetation accordingly, and adjusts some of the affected tests.
|
@rallytime, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terminalmage, @imankulov and @s0undt3ch to be potential reviewers. |
rallytime
added
the
pending-changes
rallytime
removed
the
pending-changes
Contributor
Author
|
I spoke with @terminalmage offline about this last commit and that is the way he wants to handle the call to |
Contributor
Author
|
Hooray! Test suite is no longer hanging on the git_pillar tests. This is good to go from my perspective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also removes the warnings that this default will change in the Nitrogen release, updates the documentation accordingly, and adjusts some of the affected tests.
This was originally submitted in #40899, but I had to revert it because once it was merged into the nitrogen branch, the test suite started hanging. However, I am unable to reproduce the behavior of the test suite hanging, so let's just try to submit this again.