[master] Remove usage of "mock" in favor of "unittest.mock" #65364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
meaksh
force-pushed
the
master-remove-mock
branch
from
2f36038 to
b38cbbf
Compare
meaksh
force-pushed
the
master-remove-mock
branch
from
93204c4 to
9fe69ef
Compare
3 tasks
Contributor
Author
|
Closing in favor of #65644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR simply removes the usage of
mockin favor ofunittest.mock(standard library), as after Salt dropping support for Python 3.6, there is no need to keep usingmocklibrary at the time of testing.Additionally, it removes the import of
__version__(an unused__mock_version), as this attribute was dropped and not available in Python 3.9+ (python/cpython#17977)Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes