[master] Use unittest.mock for newer Python versions #65644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
ycedres
force-pushed
the
selective-mock-import
branch
from
afdb42f to
31e53e4
Compare
3 tasks
3 tasks
ycedres
force-pushed
the
selective-mock-import
branch
from
31e53e4 to
6e11d41
Compare
ycedres
force-pushed
the
selective-mock-import
branch
from
6e11d41 to
7e83c93
Compare
ycedres
force-pushed
the
selective-mock-import
branch
from
c119bc3 to
95c9ed9
Compare
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jan 27, 2025
twangboy
requested changes
Apr 1, 2025
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
This needs to be rebased and conflicts resolved.
twangboy
approved these changes
Jul 2, 2025
twangboy
added
Tests
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR causes the test suite to use
unittest.mockinstead ofmockfor supported Python versions, so the usage of standard library components is favoured.To achieve this, the
__version__variable is removed as it was dropped from Python 3.9 and it's almost not used.The results of the test suite do not change.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.