dbus: port to zbus v5

[a-wai]

This is quite straightforward, only requiring to explicitly mark the proxies as pub.

Note: Debian just switched to this version as of yesterday.

[samcday]

Awesome, thanks for sending this :)

Note: Debian just switched to this version as of yesterday.

Ah-ha! I just bumped squeekboard to v4 a few days ago, so when I saw the subject line in my email without yet registering you as the author, my brain immediately screamed "but the Debians!" 😅

What does the timeline on zbus v5 in Debian look like? I guess it would appropriate for me to update the squeekboard MR too?

[a-wai]

my brain immediately screamed "but the Debians!" 😅

Hehe, that's kind of you, but don't worry, we're kinda used to patching deps ;) (as long as breakages aren't too hard to fix, that is)

What does the timeline on zbus v5 in Debian look like?

It has been uploaded to unstable yesterday, so it is already the only available version for new package uploads.

I guess it would appropriate for me to update the squeekboard MR too?

Probably, hoping it will be quite easy as well.

[samcday]

Just rebased your branch to see if CI works properly from forks now

[samcday]

Hehe, that's kind of you, but don't worry, we're kinda used to patching deps ;) (as long as breakages aren't too hard to fix, that is)

Hehe, well I'd still prefer to reduce the amount of work created for distro packaging duties, not arbitrarily add to it :D When I was lurking the Fedora Rust Matrix channel for a while, I observed more than a few "upstream bumped <dep> to <foo> without any commentary/context as to why 🙀"

Anyways coolio, I'll take another look at the squeekboard MR soon 👍

[samcday]

/packit build

[samcday]

Uh, hmm, interesting. Seems that the build failed in Fedora: https://download.copr.fedorainfracloud.org/results/packit/samcday-phrog-106/fedora-41-aarch64/08654498-phrog/builder-live.log.gz

error[E0581]: return type references an anonymous lifetime, which is not constrained by the fn input types
  --> tests/emergency_calls.rs:33:5
   |
33 |     async fn emergency_numbers_changed(signal_ctxt: &zbus::SignalContext<'_>) -> zbus::Result<()>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: lifetimes appearing in an associated or opaque type are not considered constrained
   = note: consider introducing a named lifetime parameter

Fedora is still on zbus 5.2, even in rawhide, maybe that's why? (It shouldn't be why, of course 😅)

[samcday]

Alright well, I see now.. The #YOLO CI changes I pushed a few mins ago indeed got the build running again ... Except pull_request_target builds the base branch rather than the PR head ref. I misread the dox - thought it only used the base upstream ref for the workflow file. Sigh.

I'm guessing what actually happened here is you based your changes on 0.44.1, but I merged some new zbus usage in the emergency calls tests (#99) a couple of days ago.

[samcday]

Sorry, just rudely rebased your branch again 🙃

[samcday]

Okay, finally coaxed the CI into a usable state, and now the build is (correctly) failing when compiling the emergency-calls test. I'm done booping your branch so feel free to update at your leisure :) I would volunteer to do it, but this time I'd like to make sure the CI behaves the right way when you push up a change 🙏

[a-wai]

I'm guessing what actually happened here is you based your changes on 0.44.1

Oops yeah, I meant to build from main then got distracted, sorry about that... I'll follow-up ASAP, either later today or tomorrow.

[a-wai]

Dammit, my brain executed cargo check (too used to meson I guess) instead of cargo test, fixing the error rn

[github-actions]

The CI build recorded and generated some videos

Demo video (shown on README and release notes)

accent-colours

emergency-calls

first-run

keypad-shuffle

simple-flow

trivial-flow

[samcday]

/packit build

[samcday]

Looking good. Thanks a bunch!