-
Notifications
You must be signed in to change notification settings - Fork 6
Add test for emergency calls #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Will be used in following commit to serialize emergency contact list over dbus Signed-off-by: Sam Day <me@samcday.com>
This allows us to trigger power menu / emergency shell in tests via Actions, rather than button presses. Signed-off-by: Sam Day <me@samcday.com>
This comment has been minimized.
This comment has been minimized.
fdcca63 to
5de3202
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Sam Day <me@samcday.com>
Properly codify selecting digits from a keypad grid. This works for PhoshKeypad as well as CuiKeypad Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
5de3202 to
de070d9
Compare
Owner
Author
|
/packit build |
Owner
Author
|
Since this is just test code to keep an eye on cui + emergency menu shell bits, I'm going to merge this as soon as I see the RPM builds succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.







We're inching closer to Guido's glorious vision. This test surfaces the emergency calling behaviour, which is all already in place. All of the work in this PR simply facilitates testing that it works.
As he noted in the phog issue however, there's likely still additional work that needs to take place for it to actually operate correctly with the real Calls in a greeter session. I'll do some testing on a device with a SIM card soon.
Part of #7