Use jl.Class'es instead of ClassTag's in structural calls. #10388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
selectable-use-jl-class
branch
2 times, most recently
from
d32635a to
9015518
Compare
This simplifies the life of everyone: the expansion of structural calls, the implementation of `scala.reflect.Selectable`, and the reverse engineering performed by the Scala.js back-end. As a side benefit, the new transformation supports bottom types in the arguments. It was previously limited because we do not allow the generation of `ClassTag`s for `Null` and `Nothing`: they are unsound in arrays, which is what `ClassTag`s are designed for, but on their own they have perfectly valid `Class`'es.
sjrd
force-pushed
the
selectable-use-jl-class
branch
from
9015518 to
574f741
Compare
odersky
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the life of everyone: the expansion of structural calls, the implementation of
scala.reflect.Selectable, and the reverse engineering performed by the Scala.js back-end.As a side benefit, the new transformation supports bottom types in the arguments. It was previously limited because we do not allow the generation of
ClassTags forNullandNothing: they are unsound in arrays, which is whatClassTags are designed for, but on their own they have perfectly validClass'es.