Make the dynamic methods of reflect.Selectable final. #10393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
approved these changes
Nov 19, 2020
tests/sjs-junit/test/org/scalajs/testsuite/compiler/CustomSelectableTestScala3.scala
Outdated
Show resolved
Hide resolved
This simplifies the life of everyone: the expansion of structural calls, the implementation of `scala.reflect.Selectable`, and the reverse engineering performed by the Scala.js back-end. As a side benefit, the new transformation supports bottom types in the arguments. It was previously limited because we do not allow the generation of `ClassTag`s for `Null` and `Nothing`: they are unsound in arrays, which is what `ClassTag`s are designed for, but on their own they have perfectly valid `Class`'es.
By making them final, the Scala.js back-end can process them not only for `reflectiveSelectable`, but for any custom subclass of `reflect.Selectable`. This removes its main limitation on Scala.js. We add `@inline` to the default implementation in `reflectiveSelectable` (which requires to make it a named class) so that the Scala.js optimizer can completely optimize it away at link time. On the JVM, this change has no effect.
sjrd
force-pushed
the
final-reflect-selectable-methods
branch
from
73ea507 to
da39683
Compare
odersky
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making them final, the Scala.js back-end can process them not only for
reflectiveSelectable, but for any custom subclass ofreflect.Selectable. This removes its main limitation on Scala.js.We add
@inlineto the default implementation inreflectiveSelectable(which requires to make it a named class) so that the Scala.js optimizer can completely optimize it away at link time. On the JVM, this change has no effect.builds on top of #10388.