Fix #3664: Run test in CI instead of testAll
#3665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
force-pushed
the
fix-#3664
branch
from
11b3b36 to
32b02dc
Compare
allanrenucci
changed the title
testAll part of commonSettingstestAll part of commonSettings
smarter
reviewed
Dec 13, 2017
project/Build.scala
Outdated
| bootstrapFromPublishedJars := false, | ||
|
|
||
| // enable improved incremental compilation algorithm | ||
| incOptions := incOptions.value.withNameHashing(true), |
Member
There was a problem hiding this comment.
This has been on by default for years.
allanrenucci
force-pushed
the
fix-#3664
branch
from
c596edb to
7dc02c0
Compare
allanrenucci
changed the title
testAll part of commonSettingstest in CI instead of testAll
allanrenucci
force-pushed
the
fix-#3664
branch
2 times, most recently
from
9ef1b8d to
545a42e
Compare
nicolasstucki
suggested changes
Dec 14, 2017
Contributor
nicolasstucki
left a comment
nicolasstucki
left a comment
There was a problem hiding this comment.
SlowTests should only execute on the CI or under testOnly.
We remove `testAll` which is now equivalent to `test`. If one only want to run the compilation tests, he can use the `vulpix` command. This commit also, clean the sbt build
allanrenucci
force-pushed
the
fix-#3664
branch
from
545a42e to
1f25a04
Compare
nicolasstucki
approved these changes
Dec 18, 2017
allanrenucci
added a commit
to dotty-staging/dotty
that referenced
this pull request
Dec 18, 2017
allanrenucci
added a commit
that referenced
this pull request
Jan 4, 2018
Update documentation after #3665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove
testAllwhich is now equivalent totest. If one only want to run the compilation tests, he can use thevulpixcommand.This commit also, clean the sbt build