Skip to content

Conversation

@allanrenucci
Copy link
Contributor

No description provided.

@allanrenucci allanrenucci requested a review from smarter December 18, 2017 17:38
@smarter
Copy link
Member

smarter commented Dec 18, 2017

LGTM. Though I find it weird to call this testCompilation when it also runs tests :).

@allanrenucci
Copy link
Contributor Author

Do you a better alternative? I am happy to change the name. Martin wanted something that starts with "test" so that the command can be discovered using autocompletion in sbt

@smarter
Copy link
Member

smarter commented Dec 18, 2017 via email

@allanrenucci
Copy link
Contributor Author

Merging this since testCompilation has been around for some time now.

@allanrenucci allanrenucci merged commit 55f8819 into scala:master Jan 4, 2018
@allanrenucci allanrenucci deleted the doc branch January 4, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants