Add List[Expr[T]] to Expr[List[T]] conversion in the library
#5543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def toExpr(implicit ev: Liftable[T]): Expr[T] = ev.toExpr(x) | ||
| } | ||
|
|
||
| implicit class ListOfExprOps[T](val list: List[Expr[T]]) extends AnyVal { |
Contributor
There was a problem hiding this comment.
Don't you have this conversion for free if you make Liftable[List[T]] implicitly available?
Contributor
Author
There was a problem hiding this comment.
No, Liftable[List[T]] transforms List[T] into Expr[List[T]]. But here we transform List[Expr[T]] into Expr[List[T]].
Contributor
Author
There was a problem hiding this comment.
This is a generalisation of your liftListOfAny.
Contributor
Author
|
This PR may silently conflict with #5520 |
liufengyun
approved these changes
Dec 3, 2018
Contributor
liufengyun
left a comment
liufengyun
left a comment
There was a problem hiding this comment.
LGTM for this PR
Question for later: what about Seq?
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
scalatestand the interpolators need this operation and they are probably not the only ones.