Skip to content

Add List[Expr[T]] to Expr[List[T]] conversion in the library #5543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolasstucki merged 2 commits into from
Dec 3, 2018
Merged

Add List[Expr[T]] to Expr[List[T]] conversion in the library #5543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26cec65
Move scala.quoted package object to scala 3 sources
nicolasstucki Nov 29, 2018
8c0178e
Add List[Expr[T]] to Expr[List[T]] conversion in the library
nicolasstucki Nov 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions library/src-scala3/scala/quoted/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package scala

package object quoted {

implicit class LiftExprOps[T](val x: T) extends AnyVal {
def toExpr(implicit ev: Liftable[T]): Expr[T] = ev.toExpr(x)
}

implicit class ListOfExprOps[T](val list: List[Expr[T]]) extends AnyVal {
Copy link
Contributor

@allanrenucci allanrenucci Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you have this conversion for free if you make Liftable[List[T]] implicitly available?

Copy link
Contributor Author

@nicolasstucki nicolasstucki Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Liftable[List[T]] transforms List[T] into Expr[List[T]]. But here we transform List[Expr[T]] into Expr[List[T]].

Copy link
Contributor Author

@nicolasstucki nicolasstucki Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generalisation of your liftListOfAny.

def toExprOfList(implicit ev: Type[T]): Expr[List[T]] = {
def rec(list: List[Expr[T]]): Expr[List[T]] = list match {
case x :: xs => '{ (~x) :: (~rec(xs)) }
case Nil => '(Nil)
}
rec(list)
}
}
}
9 changes: 0 additions & 9 deletions library/src/scala/quoted/package.scala
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions tests/run-separate-compilation/xml-interpolation-2/XmlQuote_1.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,7 @@ object XmlQuote {
// [a0, ...]: Any*
val args2: Expr[List[Any]] = args.unseal.underlyingArgument match {
case Typed(Repeated(args0), _) => // statically known args, make list directly
def liftListOfAny(lst: List[Expr[Any]]): Expr[List[Any]] = lst match {
case x :: xs => '{ ~x :: ~liftListOfAny(xs) }
case Nil => '(Nil)
}
liftListOfAny(args0.map(_.seal[Any]))
args0.map(_.seal[Any]).toExprOfList
case _ =>
'((~args).toList)

Expand Down