Support OS400 system#139
Conversation
|
@mayeut , Hi , I am new to this project. Can you help review this PR ? Or help to find a correct reviewer for it ? Thanks. |
|
Can we avoid |
|
Yes, In theory, it should work on other platform as well. But I do not want to break other platforms with my PR. :-). If they wish, they can also follow this way. Or , do you want me to make it done as well for all platforms? thanks. |
|
I was waiting to see if @mayeut had any comment, since he's been involved in helping with some of these sorts of systems & Ninja. I'd say yes, because then it's much easier to test and see if the new configuration system is working. I don't have an OS400 system to see if the new code works. |
|
(but don't destroy your history, in case it needs revision) |
|
@mayeut , any comments ? thanks. |
|
Anyway, I am following the @henryiii 's suggestion to trying using the cmake on all platforms instead of IBM i only. Wish this would pass all the integration test on your available systems. I have verified on IBM i platform. thanks. |
mayeut
left a comment
There was a problem hiding this comment.
Sorry for jumping in so late in the process.
LGTM, I'm just a bit scared of changing this because we don't have that much tests but I'll add some more in another PR.
|
Thanks for your help guys. @mayeut , can I know when can we have a release with this code available? I noticed that seems we didn't release anything in the whole of 2022? :-(. |
This PR is for OS400 system support. Can anybody kindly help to review and merge it? thanks.
"configure.py" is deprecated in ninja-build project, and it does not support OS400 system.