chore: run ninja test suite as part of the build#142
Merged
Conversation
Contributor
Author
|
@zheddie, can you confirm this PR works for you on OS400 systems ? |
henryiii
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #139 (review), run Ninja test suite as part of the build
In #139 review, I focused on the diff only. With the full picture when adding tests, it seems that we can follow the same build workflow for Linux & macOS/Windows.
#139 effectively bumped the minimum CMake version to 3.15 (the one required by Ninja itself), so this was bumped here as well.