feat: use a manylinux_2_31 compatible image for riscv64#312
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the RISC-V 64-bit manylinux image configuration to use a custom Ubuntu-based image that provides better compatibility than the default PyPA manylinux image by downgrading from manylinux_2_39 to manylinux_2_31.
- Replaces the default
manylinux_2_39image with a customghcr.io/mayeut/manylinux_2_31:2025.08.02-2image for RISC-V 64-bit builds
Comments suppressed due to low confidence (1)
pyproject.toml:103
- The image tag references date '2025.08.02-2', but it's currently August 2025. This suggests the image may not exist yet or the date is incorrect.
manylinux-riscv64-image = "ghcr.io/mayeut/manylinux_2_31:2025.08.02-2"
93e9fb8 to
97c0d95
Compare
| manylinux-s390x-image = "manylinux2014" | ||
| manylinux-armv7l-image = "manylinux_2_31" | ||
| manylinux-riscv64-image = "manylinux_2_39" | ||
| manylinux-riscv64-image = "ghcr.io/mayeut/manylinux_2_31:2025.08.02-2" |
There was a problem hiding this comment.
Do you happen to have a link to the updated Dockerfile ?
(Could not find it looking at https://github.com/mayeut/manylinux/branches)
There was a problem hiding this comment.
Do you happen to have a link to the updated Dockerfile ?
Those images are not part of pypa/manylinux or my fork but are maintained in a different repository: https://github.com/mayeut/manylinux-ubuntu
The python packages come from a ppa (one per distro version, in this case https://launchpad.net/~mayeut-github/+archive/ubuntu/python-focal/+packages) which rebuilds packages from the deadsnakes ppa for all platforms (deadsnakes currently does not build for riscv64).
They get the same tools as pypa/manylinux images & run the same set of tests (using a sub-module on pypa/manylinux).
There was a problem hiding this comment.
Thanks for the thorough answer 🙏 And for maintaining the associated infrastructure 💯
This ubuntu based image provides better compatibility than the default `manylinux_2_39` pypa/manylinux image.
97c0d95 to
ccdd9c2
Compare
This ubuntu based image provides better compatibility than the default
manylinux_2_39pypa/manylinux image.I think it's nice to have this for a base tool like ninja.
Other alternatives: