Skip to content

feat: use a manylinux_2_31 compatible image for riscv64#312

Merged
jcfr merged 1 commit into
scikit-build:masterfrom
mayeut:riscv64-manylinux_2_31
Aug 8, 2025
Merged

feat: use a manylinux_2_31 compatible image for riscv64#312
jcfr merged 1 commit into
scikit-build:masterfrom
mayeut:riscv64-manylinux_2_31

Conversation

@mayeut
Copy link
Copy Markdown
Contributor

@mayeut mayeut commented Aug 2, 2025

This ubuntu based image provides better compatibility than the default manylinux_2_39 pypa/manylinux image.

I think it's nice to have this for a base tool like ninja.
Other alternatives:

  • the custom ubuntu based manylinux_2_35 image from the same repo which can also be used for cmake (OpenSSL does not build on manylinux_2_31 in the cmake repo but manylinux_2_35 works just fine)
  • just close this & keep the default manylinux_2_39 image

@mayeut mayeut mentioned this pull request Aug 2, 2025
3 tasks
@mayeut mayeut requested a review from Copilot August 2, 2025 14:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the RISC-V 64-bit manylinux image configuration to use a custom Ubuntu-based image that provides better compatibility than the default PyPA manylinux image by downgrading from manylinux_2_39 to manylinux_2_31.

  • Replaces the default manylinux_2_39 image with a custom ghcr.io/mayeut/manylinux_2_31:2025.08.02-2 image for RISC-V 64-bit builds
Comments suppressed due to low confidence (1)

pyproject.toml:103

  • The image tag references date '2025.08.02-2', but it's currently August 2025. This suggests the image may not exist yet or the date is incorrect.
manylinux-riscv64-image = "ghcr.io/mayeut/manylinux_2_31:2025.08.02-2"

@mayeut mayeut requested review from henryiii and jcfr August 2, 2025 14:57
@mayeut mayeut force-pushed the riscv64-manylinux_2_31 branch from 93e9fb8 to 97c0d95 Compare August 2, 2025 17:21
Comment thread pyproject.toml
manylinux-s390x-image = "manylinux2014"
manylinux-armv7l-image = "manylinux_2_31"
manylinux-riscv64-image = "manylinux_2_39"
manylinux-riscv64-image = "ghcr.io/mayeut/manylinux_2_31:2025.08.02-2"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to have a link to the updated Dockerfile ?

(Could not find it looking at https://github.com/mayeut/manylinux/branches)

Copy link
Copy Markdown
Contributor Author

@mayeut mayeut Aug 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to have a link to the updated Dockerfile ?

Those images are not part of pypa/manylinux or my fork but are maintained in a different repository: https://github.com/mayeut/manylinux-ubuntu

The python packages come from a ppa (one per distro version, in this case https://launchpad.net/~mayeut-github/+archive/ubuntu/python-focal/+packages) which rebuilds packages from the deadsnakes ppa for all platforms (deadsnakes currently does not build for riscv64).

They get the same tools as pypa/manylinux images & run the same set of tests (using a sub-module on pypa/manylinux).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough answer 🙏 And for maintaining the associated infrastructure 💯

This ubuntu based image provides better compatibility than the default `manylinux_2_39` pypa/manylinux image.
@mayeut mayeut force-pushed the riscv64-manylinux_2_31 branch from 97c0d95 to ccdd9c2 Compare August 3, 2025 05:15
@mayeut mayeut requested a review from jcfr August 7, 2025 05:04
@jcfr jcfr merged commit 1e7b6f3 into scikit-build:master Aug 8, 2025
21 checks passed
@mayeut mayeut deleted the riscv64-manylinux_2_31 branch August 17, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants