Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you happen to have a link to the updated Dockerfile ?
(Could not find it looking at https://github.com/mayeut/manylinux/branches)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those images are not part of pypa/manylinux or my fork but are maintained in a different repository: https://github.com/mayeut/manylinux-ubuntu
The python packages come from a ppa (one per distro version, in this case https://launchpad.net/~mayeut-github/+archive/ubuntu/python-focal/+packages) which rebuilds packages from the deadsnakes ppa for all platforms (deadsnakes currently does not build for riscv64).
They get the same tools as pypa/manylinux images & run the same set of tests (using a sub-module on pypa/manylinux).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thorough answer 🙏 And for maintaining the associated infrastructure 💯