add micro-based httpd image for c8s, c9s and Fedora#138
add micro-based httpd image for c8s, c9s and Fedora#138pkubatrh merged 14 commits intosclorg:masterfrom
Conversation
|
[test] |
1 similar comment
|
[test] |
pkubatrh
changed the title
pkubatrh
force-pushed
the
micro
branch
2 times, most recently
from
c12f6f2 to
3a9d09c
Compare
|
[test] |
|
[test-all] |
pkubatrh
force-pushed
the
micro
branch
2 times, most recently
from
0e3fcf6 to
f6b93a4
Compare
|
[test-all] |
|
[test-all] |
pkubatrh
changed the title
|
[test-all] |
2 similar comments
|
[test-all] |
|
[test-all] |
pkubatrh
changed the title
|
[test-all] |
|
[test-all] |
3 similar comments
|
[test-all] |
|
[test-all] |
|
[test-all] |
| @@ -0,0 +1 @@ | |||
| . No newline at end of file | |||
There was a problem hiding this comment.
@phracek said in case of nginx-container that this kind of symlink breaks upstream->downstream. Not sure whether also in this case.
There was a problem hiding this comment.
What is the issue with this approach? Iirc cwt during syncs actually creates this symlink by default.
|
[test-all] |
1 similar comment
|
[test-all] |
|
De-duplication should be possible as I do not think I made that many changes from full 2.4, but will need some work. We can follow up in a separate PR. |
|
Centos7 CI failing due to unavailable "dnf-utils" which is an issue of the underlying infrastructure (there is no dnf in centos7). @phracek Can you take a look again if everything is ok and as expected with this PR now? |
|
[test-all] |
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
Thanks for bringing httpd-micro container. Can you please look at my proposals and address them or comment on them? Thanks.
| @@ -0,0 +1,21 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Please create a symlink as @hhorak proposes. It makes sense to me as well.
|
After committing the suggestion I for some reason cannot reply on the rest of the comments :/ So adding the responses here:
Right I forgot about this. I will add some part that explains the differences.
As mentioned in a previous comment, I am planning to move to shared files in a separate PR, as I do not want to hold this up much longer. |
|
[test-all] |
Co-authored-by: Petr Hracek <phracek@redhat.com>
|
[test-all] |
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
LGTM. Tests are passing. Let's get merge it and solve issues like common scripts by separate PR. Please create an issue for it, so we do not forget.
3 participants
No description provided.