Merged
Conversation
both rhel8 and rhel9 images are available in UBI
zmiklank
reviewed
Aug 10, 2022
Contributor
zmiklank
left a comment
zmiklank
left a comment
There was a problem hiding this comment.
The c9s and c8s is also mentioned in run_default_page_test and run_as_root_test functions that are part of 2.4/test/run.
Do we want to address also that?
Else LGTM.
Member
Author
|
Thanks for the review!
I kept those in for the future case where we introduce a new version of httpd that we want to ship in either Stream. Merging without tests as the changes will only take effect after the PR is merged (and I will be running tests as part of #138 anyway) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both rhel8 and rhel9 images are available in UBI