Make NToString and friends free functions #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMory
reviewed
Aug 4, 2023
| OS << "Call string: [ "; | ||
| for (auto C : CallString) { | ||
| NP.printNode(OS, C); | ||
| OS << NToString((C)); |
MMory
approved these changes
Aug 4, 2023
Member
MMory
left a comment
MMory
left a comment
There was a problem hiding this comment.
looks good, thanks! Nice cleanup!
* Make IDETypeStateDescription a template to allow for type-safe type states * Implement JoinLatticeTraits for CSTDFILEIOState * Move TSA flow functions to source file again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the printers
NToString,DToString, etc. are pure virtual functions that have to be implemented by each analysis problem. However, the vast majority of all implementations of these functions is exactly the same (delegating to eitherllvmIRToString()or tooperator<<) and independent from the analysis problem instance.To simplify the usage of these functions as well as to simplify implementations of
IDETabulationProblem, these printer functions are now free functions directly within the namespacepsr. They now have a useful default implementation and can be easily extended via normal function overloading.Note: The only painpoint currently is the Typestate Analysis -- the only analysis where
LToStringreally depends on the analysis.This PR, thus, slightly adapts the
l_ttype of the TSA to cope with this issue. A better solution is welcome and may come in its own PR.