Template Typestate Analysis #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianbs96
added a commit
that referenced
this pull request
Aug 24, 2023
* Make NToString and friends free functions * Remove double parentheses * Template Typestate Analysis (#654) * Make IDETypeStateDescription a template to allow for type-safe type states * Implement JoinLatticeTraits for CSTDFILEIOState * Move TSA flow functions to source file again --------- Co-authored-by: Martin Mory <mmo@mail.upb.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typestate analysis is the only analysis in phasar where one printer function (
LToString) depends on the concrete analysis instance. This is, because the TypestateDescription defines, how a type state should be printed.Moving to free-printers (#652) would then require to make the type state itself a virtual type that knows how it should printed. This is not only ugly, but may also have a performance impact.
To fix this issue, this PR makes the typestate analysis a template enabling type-safe type states.