-
-
Notifications
You must be signed in to change notification settings - Fork 799
feat(jellyfin): allow Jellyfin Guids with dashes for import-from-jellyfin endpoint #2340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+30
−4
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0ff8d55
Add Jellyfin GUID normalization and comparison functions
its-wizza 98a805e
Remove jellyfinGuidsEqual function
its-wizza 72d8a34
Allow multiple Jellyfin Guid formats for user import
its-wizza d9d1aa0
Refactor normalizeJellyfinGuid to simplify value check
its-wizza f2caaf2
fix: handle null from normalize function
its-wizza a107148
style: i18n
its-wizza 66f8a27
refactor: remove i18n change, irrelevant
its-wizza b110fa2
Merge branch 'develop' into jellyfin-guid-fix
its-wizza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| export function normalizeJellyfinGuid( | ||
| value: string | null | undefined | ||
| ): string | null { | ||
| if (!value) { | ||
| return null; | ||
| } | ||
|
|
||
| const normalized = value.replace(/-/g, '').toLowerCase(); | ||
|
|
||
| if (!/^[0-9a-f]{32}$/.test(normalized)) { | ||
| return null; | ||
| } | ||
|
|
||
| return normalized; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.