feat(jellyfin): allow Jellyfin Guids with dashes for import-from-jellyfin endpoint

[its-wizza]

Description

• Allows GUIDs with hyphens as post data to import-from-jellyfin endpoint to align with Jellyfin standards where both with and without dashes is supported (with dashes is preferred)
• Don't think any other endpoints are affected by the change to support these Jellyfin Guids
• Fixes API support for Jellyfin Guid with dashes #2338
• Note: Used AI as a starting point for code

How Has This Been Tested?

Built locally, connected to Jellyfin server and sent POST request to import-from-jellyfin endpoint with Guid with dashes, successfully added user

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• [N/A] I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• [N/A] Translation keys pnpm i18n:extract
• [N/A] Database migration (if required)

Summary by CodeRabbit

• Bug Fixes

  • Improved handling and validation of Jellyfin user identifiers to ensure consistency and prevent lookup failures.

• Performance

  • Enhanced user lookup efficiency with optimized data structure for faster ID resolution.

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[gauthier-th]

LGTM

[gauthier-th]

@its-wizza can you please fix the merge conflict?

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes add support for Jellyfin Guids formatted with dashes by introducing a normalization utility function that removes hyphens and validates the format, then applying it during user import to enable map-based lookups instead of linear search.

Changes

Cohort / File(s)	Summary
Jellyfin Guid Normalization Utility server/utils/jellyfin.ts	New exported function normalizeJellyfinGuid that accepts string/null/undefined, removes hyphens, converts to lowercase, and validates against 32 hex characters before returning normalized value or null.
User Import Route Handler server/routes/user/index.ts	Applies normalization to imported Jellyfin user IDs by constructing a jellyfinUsersById map keyed by normalized IDs and replacing linear search with map-based lookup for improved performance and support for both hyphenated and non-hyphenated Guid formats.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A dash of flexibility, a hop and a bound,
Jellyfin Guids now dance all around,
With hyphens or bare, the format's refined,
Map lookups now swift, leave searches behind! ✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: adding support for Jellyfin GUIDs with dashes in the import endpoint.
Linked Issues check	✅ Passed	The code changes implement both objectives from issue #2338: normalizing GUIDs to handle both dashed and non-dashed formats, and applying this to the /import-from-jellyfin endpoint.
Out of Scope Changes check	✅ Passed	All changes are scoped to Jellyfin GUID handling and the import endpoint as required; no unrelated modifications are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

server/routes/user/index.ts (1)

690-712: ⚠️ Potential issue | 🔴 Critical

Guard unresolved Jellyfin users and align ID lookup format before create.

At Line 696, jellyfinUsersById.get(...) can return undefined; the current code still reaches user creation (Lines 705-712) with optional fields, which can create invalid records or fail the request.
Also at Line 700, lookup uses only normalized ID, but Line 706 stores raw jellyfinUser.Id (often dashed), so re-imports can miss existing users.

💡 Proposed fix

 for (const rawJellyfinUserId of body.jellyfinUserIds) {
   const jellyfinUserId = normalizeJellyfinGuid(rawJellyfinUserId);
   if (!jellyfinUserId) {
     continue;
   }

   const jellyfinUser = jellyfinUsersById.get(jellyfinUserId);
+  if (!jellyfinUser) {
+    continue;
+  }

   const user = await userRepository.findOne({
     select: ['id', 'jellyfinUserId'],
-    where: { jellyfinUserId: jellyfinUserId },
+    where: [
+      { jellyfinUserId },
+      { jellyfinUserId: jellyfinUser.Id },
+    ],
   });

   if (!user) {
     const newUser = new User({
-      jellyfinUsername: jellyfinUser?.Name,
-      jellyfinUserId: jellyfinUser?.Id,
+      jellyfinUsername: jellyfinUser.Name,
+      jellyfinUserId: jellyfinUser.Id,
       jellyfinDeviceId: Buffer.from(
-        `BOT_seerr_${jellyfinUser?.Name ?? ''}`
+        `BOT_seerr_${jellyfinUser.Name}`
       ).toString('base64'),
-      email: jellyfinUser?.Name,
+      email: jellyfinUser.Name,
       permissions: settings.main.defaultPermissions,
-      avatar: `/avatarproxy/${jellyfinUser?.Id}`,
+      avatar: `/avatarproxy/${jellyfinUser.Id}`,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/routes/user/index.ts` around lines 690 - 712, The loop currently can
create users when jellyfinUsersById.get(...) returns undefined and it stores the
raw jellyfinUser.Id (dashed) which mismatches the normalized lookup; change the
logic to skip processing when jellyfinUser is undefined (i.e., if
(!jellyfinUser) continue) and when creating a new User use the
already-normalized jellyfinUserId variable for the stored jellyfinUserId, for
the jellyfinDeviceId seed, and for the avatar path (instead of
jellyfinUser?.Id), ensuring userRepository.findOne, normalizeJellyfinGuid,
jellyfinUsersById, and the User constructor consistently use the normalized ID.

🧹 Nitpick comments (1)

server/routes/user/index.ts (1)

683-688: Filter invalid normalized IDs before inserting into the map.

normalizeJellyfinGuid(user.Id) can return null, which currently creates a nullable map key path. Filtering these entries keeps the map strictly keyed by valid GUIDs and avoids null-key collisions.

♻️ Proposed refactor

-const jellyfinUsersById = new Map(
-  jellyfinUsers.users.map((user) => [
-    normalizeJellyfinGuid(user.Id),
-    user,
-  ])
-);
+const jellyfinUsersById = new Map(
+  jellyfinUsers.users.flatMap((user) => {
+    const normalizedId = normalizeJellyfinGuid(user.Id);
+    return normalizedId ? [[normalizedId, user] as const] : [];
+  })
+);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/routes/user/index.ts` around lines 683 - 688, The Map construction for
jellyfinUsersById uses normalizeJellyfinGuid(user.Id) which can return null;
change the creation to filter out entries with a null normalized ID before
inserting into the Map so keys are always valid GUIDs — e.g., iterate
jellyfinUsers.users and for each user compute const id =
normalizeJellyfinGuid(user.Id), skip the user if id is null, otherwise add [id,
user] to the Map; update the code paths around jellyfinUsersById to rely on the
strictly keyed Map.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@server/routes/user/index.ts`:
- Around line 690-712: The loop currently can create users when
jellyfinUsersById.get(...) returns undefined and it stores the raw
jellyfinUser.Id (dashed) which mismatches the normalized lookup; change the
logic to skip processing when jellyfinUser is undefined (i.e., if
(!jellyfinUser) continue) and when creating a new User use the
already-normalized jellyfinUserId variable for the stored jellyfinUserId, for
the jellyfinDeviceId seed, and for the avatar path (instead of
jellyfinUser?.Id), ensuring userRepository.findOne, normalizeJellyfinGuid,
jellyfinUsersById, and the User constructor consistently use the normalized ID.

---

Nitpick comments:
In `@server/routes/user/index.ts`:
- Around line 683-688: The Map construction for jellyfinUsersById uses
normalizeJellyfinGuid(user.Id) which can return null; change the creation to
filter out entries with a null normalized ID before inserting into the Map so
keys are always valid GUIDs — e.g., iterate jellyfinUsers.users and for each
user compute const id = normalizeJellyfinGuid(user.Id), skip the user if id is
null, otherwise add [id, user] to the Map; update the code paths around
jellyfinUsersById to rely on the strictly keyed Map.

---

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c23117e and b110fa2.

📒 Files selected for processing (2)

• server/routes/user/index.ts
• server/utils/jellyfin.ts

[Copilot]

Pull request overview

Adds normalization for Jellyfin GUIDs so the /import-from-jellyfin endpoint accepts both dashed (preferred by Jellyfin) and non-dashed formats, improving interoperability with Jellyfin tooling (e.g., webhooks).

Changes:

• Introduces normalizeJellyfinGuid() utility to strip dashes, lowercase, and validate GUIDs.
• Updates /import-from-jellyfin to normalize incoming IDs and perform user lookup via a prebuilt ID map for faster resolution.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
server/utils/jellyfin.ts	Adds a helper to normalize/validate Jellyfin GUID inputs.
server/routes/user/index.ts	Uses the normalization helper and a Map to match Jellyfin users even when request IDs contain dashes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.