fix(entities): replace MySQL-only onUpdate with @UpdateDateColumn

[fallenbagel]

Description

onUpdate: 'CURRENT_TIMESTAMP' in @DbAwareColumn is a MySQL-only feature that does nothing on SQLite or PostgreSQL, which are the only two databases we support (see also typeorm/typeorm#7347).

This means updatedAt was never being automatically refreshed on any supported database. This replaces the broken onUpdate columns with @UpdateDateColumn() across all 10 affected entities, which TypeORM handles at the ORM level so every .save() call automatically updates the timestamp regardless of database backend. See #2729 (review) for the full breakdown.

Supersedes #2729

• Fixes Date Modified on Requests Not Accurate #2728

How Has This Been Tested?

@UpdateDateColumn is a well-documented TypeORM decorator and the change is a direct swap with no logic changes. Verified with a successful build.

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Refactor
  • Standardized "last updated" timestamp behavior across multiple data entities to use the framework's managed update-timestamp mechanism, improving consistency and reliability of update times and simplifying maintenance.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9ec3de1d-600b-4268-906d-ae5d1d7cd19d

📥 Commits

Reviewing files that changed from the base of the PR and between be97960 and e82f977.

📒 Files selected for processing (10)

• server/entity/DiscoverSlider.ts
• server/entity/Issue.ts
• server/entity/IssueComment.ts
• server/entity/Media.ts
• server/entity/MediaRequest.ts
• server/entity/OverrideRule.ts
• server/entity/Season.ts
• server/entity/SeasonRequest.ts
• server/entity/User.ts
• server/entity/Watchlist.ts

🚧 Files skipped from review as they are similar to previous changes (8)

• server/entity/User.ts
• server/entity/Media.ts
• server/entity/DiscoverSlider.ts
• server/entity/MediaRequest.ts
• server/entity/Watchlist.ts
• server/entity/Season.ts
• server/entity/Issue.ts
• server/entity/SeasonRequest.ts

---

📝 Walkthrough

Walkthrough

Refactored multiple entity files to replace custom @DbAwareColumn configurations for updatedAt with TypeORM's @UpdateDateColumn({ type: resolveDbType('datetime') }), and updated imports accordingly across the affected entities.

Changes

Cohort / File(s)	Summary
Entity Timestamp Refactor server/entity/DiscoverSlider.ts, server/entity/Issue.ts, server/entity/IssueComment.ts, server/entity/Media.ts, server/entity/MediaRequest.ts, server/entity/OverrideRule.ts, server/entity/Season.ts, server/entity/SeasonRequest.ts, server/entity/User.ts, server/entity/Watchlist.ts	Replaced @DbAwareColumn({ type: 'datetime', default: () => 'CURRENT_TIMESTAMP', onUpdate: 'CURRENT_TIMESTAMP' }) with @UpdateDateColumn({ type: resolveDbType('datetime') }) for updatedAt. Updated imports to add UpdateDateColumn from typeorm and resolveDbType from @server/utils/DbColumnHelper; removed previous onUpdate-based config usage.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(issues): update issue timestamp when adding comments #2616: Modifies Issue.updatedAt handling and sets update timestamps when adding comments; touches the same timestamp logic.

Suggested reviewers

• gauthier-th
• danshilm
• 0xSysR3ll

Poem

🐰 In rows of data, timestamps bloom,
I hopped and fixed the update-room.
From custom tricks to TypeORM's care,
Now "Modified" shows when changes were fair.
Hooray — the dates are true, I swear! 🥕✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: replacing MySQL-only onUpdate behavior with TypeORM's @UpdateDateColumn decorator across multiple entity files.
Linked Issues check	✅ Passed	The PR addresses issue #2728 by replacing MySQL-only onUpdate with @UpdateDateColumn, ensuring updatedAt timestamps are automatically refreshed across all supported databases (SQLite, PostgreSQL, MySQL).
Out of Scope Changes check	✅ Passed	All changes are focused on replacing @DbAwareColumn with @UpdateDateColumn for updatedAt fields across 10 entity files, directly addressing the linked issue with no extraneous modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/entity/Media.ts`:
- Around line 133-134: The `@UpdateDateColumn`() decorator for the updatedAt
property should explicitly declare the timestamp-with-timezone type to match the
migration and the createdAt pattern; update the updatedAt declaration in the
Media class (symbol: updatedAt, decorator: `@UpdateDateColumn`) to include the
same type option used for createdAt so it maps to TIMESTAMP WITH TIME ZONE
(consistent with 1746811308203-FixIssueTimestamps.ts).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62403e85-ac1f-456d-b2d3-93f07103fece

📥 Commits

Reviewing files that changed from the base of the PR and between dc40ca4 and be97960.

📒 Files selected for processing (10)

• server/entity/DiscoverSlider.ts
• server/entity/Issue.ts
• server/entity/IssueComment.ts
• server/entity/Media.ts
• server/entity/MediaRequest.ts
• server/entity/OverrideRule.ts
• server/entity/Season.ts
• server/entity/SeasonRequest.ts
• server/entity/User.ts
• server/entity/Watchlist.ts

[Copilot]

Pull request overview

Updates entity updatedAt tracking to be database-agnostic across the supported SQLite and PostgreSQL backends by replacing MySQL-only onUpdate: 'CURRENT_TIMESTAMP' usage with TypeORM’s @UpdateDateColumn().

Changes:

• Replace @DbAwareColumn(... onUpdate: 'CURRENT_TIMESTAMP') with @UpdateDateColumn() for updatedAt across 10 entities.
• Use resolveDbType('datetime') to preserve existing Postgres type mapping (datetime → timestamp with time zone) for updatedAt.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
server/entity/Watchlist.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.
server/entity/User.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.
server/entity/SeasonRequest.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.
server/entity/Season.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.
server/entity/OverrideRule.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.
server/entity/MediaRequest.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.
server/entity/Media.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.
server/entity/IssueComment.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.
server/entity/Issue.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.
server/entity/DiscoverSlider.ts	Switch updatedAt to @UpdateDateColumn with DB-aware datetime type mapping.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.