fix(watchlist-sync): handle empty watchlists on PostgreSQL

[redondos]

Description

Fixes watchlist sync silently failing on PostgreSQL when a user has an empty watchlist.

Two issues:

1. When a user has watchlistSyncMovies or watchlistSyncTv enabled but their Plex watchlist contains 0 items, the existingAutoRequests query passes an empty array to TypeORM's IN (:...tmdbIds), generating IN () — valid in SQLite but a syntax error in PostgreSQL.

2. The scheduler calls syncWatchlist() without .catch(), so the resulting QueryFailedError is an unhandled promise rejection that silently kills the sync loop for all users, not just the one with the empty watchlist.

Changes:

• server/lib/watchlistsync.ts: Short-circuit existingAutoRequests to [] when watchlistTmdbIds is empty, skipping the query entirely.
• server/job/schedule.ts: Add .catch() to the syncWatchlist() call so errors are logged instead of silently dropped.

How Has This Been Tested?

Reproduced on a PostgreSQL-backed Seerr 3.1.0 instance with 13 users. User with 0 watchlist items caused QueryFailedError: syntax error at or near ")" on every sync cycle, preventing all other users' watchlists from syncing. After this fix, the sync completes successfully for all users.

Screenshots / Logs (if applicable)

N/A

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy): AI (Claude) was used to generate the fix.
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds error handling for the Plex Watchlist Sync job using promise rejection catching and modifies auto-request lookup to conditionally execute only when watchlist tmdbIds exist, avoiding unnecessary queries.

Changes

Cohort / File(s)	Summary
Watchlist Sync Job Improvements server/job/schedule.ts, server/lib/watchlistsync.ts	Added .catch() error handling for promise rejection in watchlist sync job; modified auto-request lookup to conditionally query only when watchlist contains tmdbIds, with explicit type annotation for existingAutoRequests.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

bug

Suggested reviewers

• fallenbagel
• gauthier-th

Poem

🐰 A watchlist sync, once bare and unguarded,
Now catches its errors with promise regard,
And queries run smart—no tmdbIds, no care,
This rabbit hops proudly through code that's most fair! ✨

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title clearly and directly summarizes the main change: fixing watchlist sync to handle empty watchlists specifically on PostgreSQL, which matches the core issue described in the objectives.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

[fallenbagel]

Fixes Keywords that have no entries still show in autocomplete #2720

Isn't that the wrong issue?

[Copilot]

Pull request overview

Fixes Plex watchlist sync failures on PostgreSQL when a user’s watchlist is empty, and prevents the scheduled sync job from failing silently due to unhandled promise rejections.

Changes:

• Skip the existingAutoRequests TypeORM query when the watchlist TMDB ID list is empty (avoids generating IN () on Postgres).
• Add error handling to the scheduled syncWatchlist() invocation so failures are logged instead of becoming unhandled rejections.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
server/lib/watchlistsync.ts	Guards the IN (:...tmdbIds) query to avoid invalid SQL when the watchlist is empty.
server/job/schedule.ts	Wraps the scheduled watchlist sync call with .catch() to ensure failures are logged and don’t become unhandled promise rejections.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.