fix(email): preserve newlines in PGP key textarea fields

[fallenbagel]

Description

The PGP Private Key field in email notification settings was silently stripping newline characters, causing OpenPGP encryption to fail with a "Misformed armored text" error at send time.

When the sensitive input component was in its default hidden state, textarea fields were being rendered as single-line password inputs. The browser collapses all whitespace in password inputs, so the PGP armor block lost its required line structure. Formik then synced the destroyed value back into form state, making the damage permanent even after toggling visibility.

The sensitive input component now keeps textarea fields rendered as actual textarea elements regardless of visibility state, using CSS-based masking instead of switching the element type. The PGP key validation regex has also been updated to correctly match across newlines.

• Fixes [Bug]: Web UI strips OpenPGP key newlines, causing "Misformed armored text" error #2598

How Has This Been Tested?

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Fixed sensitive textarea field rendering and styling when content is hidden.
  • Enabled PGP private key validation to correctly accept multi-line key blocks for improved compatibility.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR addresses OpenPGP key validation and display issues by updating the SensitiveInput component to always render textareas for textarea-type inputs and modifying the PGP private key validation regex to support multi-line input by adding the dotall flag.

Changes

Cohort / File(s)	Summary
Sensitive Input Textarea Handling src/components/Common/SensitiveInput/index.tsx	Modified textarea rendering logic to always render textarea elements regardless of hidden state, and updated styling to apply WebkitTextSecurity when hidden. Adjusted type resolution to use undefined for textarea types while maintaining password/text logic for other inputs.
PGP Key Validation src/components/Settings/Notifications/NotificationsEmail.tsx	Updated PGP private key validation regex to use the dotall flag (/s), enabling pattern matching across multiple lines and allowing multi-line armored PGP blocks to pass validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A rabbit hops through keys so rare,
Preserving newlines with utmost care,
Where textareas bloom and regex gleams,
PGP blocks flow like streaming dreams,
No more stripped lines, just secrets bright—
Armored text, now handled right! ✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main fix: preserving newlines in PGP key textarea fields, which is the primary change addressing the core issue.
Linked Issues check	✅ Passed	The code changes directly address all requirements from issue #2598: textarea fields now preserve newlines, CSS-based masking replaces element type switching, and regex validation supports multi-line PGP keys.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the PGP key newline stripping issue; no unrelated modifications detected in the sensitive input component or email notification validation logic.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/Common/SensitiveInput/index.tsx`:
- Around line 43-47: The current style logic in SensitiveInput (props.type ===
'textarea' && isHidden) relies on WebkitTextSecurity which isn’t supported in
Firefox <114; update the component to handle legacy Firefox by adding a fallback
when isHidden is true: render or position an overlay mask DIV over the textarea
(or alternatively render text-masked content using a monospace replacement like
repeated bullets matching length) and keep the existing WebkitTextSecurity for
modern browsers; ensure the logic is implemented around the SensitiveInput
component props.type / isHidden handling so the textarea stays visually masked
in older Firefox, and add a short comment or note in the component documenting
the browser limitation and chosen fallback approach.

---

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c23117e and e281a75.

📒 Files selected for processing (2)

• src/components/Common/SensitiveInput/index.tsx
• src/components/Settings/Notifications/NotificationsEmail.tsx

[Copilot]

Pull request overview

Fixes OpenPGP key handling in the email notification UI so multiline armored PGP blocks aren’t corrupted by the sensitive input’s hidden-state rendering behavior, preventing encryption failures like “Misformed armored text”.

Changes:

• Update PGP private key Yup validation regex to match across newlines (/s dotAll flag).
• Change SensitiveInput so type="textarea" stays a real <textarea> even when hidden, using CSS-based masking instead of switching to a password <input>.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/components/Settings/Notifications/NotificationsEmail.tsx	Allows private key validation to match multiline armored blocks.
src/components/Common/SensitiveInput/index.tsx	Prevents newline loss by keeping textarea rendering stable and masking via styles.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.